Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call compile with correct executable #3493

Merged
merged 6 commits into from
Oct 12, 2024
Merged

Call compile with correct executable #3493

merged 6 commits into from
Oct 12, 2024

Conversation

richagadgil
Copy link
Contributor

Fixing Issue #3487 where compiling with incorrect hiprtc function results in error

@richagadgil richagadgil self-assigned this Oct 1, 2024
@richagadgil richagadgil linked an issue Oct 1, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (c1f4371) to head (4f35b16).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3493   +/-   ##
========================================
  Coverage    92.17%   92.17%           
========================================
  Files          512      512           
  Lines        21385    21385           
========================================
  Hits         19712    19712           
  Misses        1673     1673           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richagadgil richagadgil marked this pull request as ready for review October 2, 2024 18:45
@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
4f35b1
Rate old
bdbe34
Diff Compare
torchvision-resnet50 64 3,261.08 3,258.84 0.07%
torchvision-resnet50_fp16 64 6,997.72 6,981.91 0.23%
torchvision-densenet121 32 2,437.15 2,436.52 0.03%
torchvision-densenet121_fp16 32 4,077.48 4,070.78 0.16%
torchvision-inceptionv3 32 1,638.19 1,640.50 -0.14%
torchvision-inceptionv3_fp16 32 2,770.13 2,764.39 0.21%
cadene-inceptionv4 16 776.53 777.25 -0.09%
cadene-resnext64x4 16 809.46 809.84 -0.05%
slim-mobilenet 64 7,535.59 7,537.85 -0.03%
slim-nasnetalarge 64 211.83 211.79 0.02%
slim-resnet50v2 64 3,506.62 3,504.89 0.05%
bert-mrpc-onnx 8 1,149.15 1,152.66 -0.30%
bert-mrpc-tf 1 475.66 463.93 2.53%
pytorch-examples-wlang-gru 1 427.58 485.39 -11.91% 🔴
pytorch-examples-wlang-lstm 1 405.24 384.58 5.37% 🔆
torchvision-resnet50_1 1 776.46 817.62 -5.03% 🔴
cadene-dpn92_1 1 435.30 399.06 9.08% 🔆
cadene-resnext101_1 1 383.07 382.30 0.20%
onnx-taau-downsample 1 342.77 343.08 -0.09%
dlrm-criteoterabyte 1 33.32 33.33 -0.03%
dlrm-criteoterabyte_fp16 1 52.72 52.74 -0.04%
agentmodel 1 9,197.77 8,377.88 9.79% 🔆
unet_fp16 2 58.97 58.79 0.31%
resnet50v1_fp16 1 931.46 937.71 -0.67%
resnet50v1_int8 1 963.67 1,041.29 -7.45% 🔴
bert_base_cased_fp16 64 1,170.02 1,170.74 -0.06%
bert_large_uncased_fp16 32 363.56 363.58 -0.00%
bert_large_fp16 1 198.98 199.03 -0.03%
distilgpt2_fp16 16 2,204.72 2,199.30 0.25%
yolov5s 1 534.50 540.42 -1.10%
tinyllama 1 43.45 43.45 0.01%
vicuna-fastchat 1 170.71 169.65 0.63%
whisper-tiny-encoder 1 418.14 418.63 -0.12%
whisper-tiny-decoder 1 426.17 430.21 -0.94%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@causten causten merged commit ddc4c0c into develop Oct 12, 2024
23 checks passed
@causten causten deleted the import_fix branch October 12, 2024 04:25
@@ -228,9 +228,15 @@ std::vector<std::vector<char>> compile_hip_src_with_hiprtc(std::vector<hiprtc_sr
bool hip_has_flags(const std::vector<std::string>& flags)
{
hiprtc_program prog{" "};
Copy link
Collaborator

@pfultz2 pfultz2 Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is variable is not used, and should be removed. Also the other hip_has_flags function should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Compile Error when importing torch after migraphx
5 participants