Skip to content

Commit

Permalink
Address review comment
Browse files Browse the repository at this point in the history
  • Loading branch information
music-dino committed Oct 16, 2024
1 parent b663a81 commit 4350be7
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ __device__ void unpack_int4(Output output, Input input)

// unpack_int4 op's normalize_compute_shape will ensure that Input::type is either uint8_t
// or int8_t
if constexpr(is_same<typename Input::type, uint8_t>::value)
if constexpr(is_unsigned<typename Input::type>{})
output[idx] = input_val & 0xfu;
else
// NOLINTNEXTLINE (hicpp-signed-bitwise)
Expand Down

0 comments on commit 4350be7

Please sign in to comment.