Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade spring 6.1.4 #1477

Merged
merged 2 commits into from
Jun 13, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
<shedlock.version>5.13.0</shedlock.version>
<slf4j.version>2.0.12</slf4j.version>
<solrj.version>1.4.1</solrj.version>
<spring.version>6.1.8</spring.version>
<spring.version>6.1.4</spring.version>
<spock.version>2.3-groovy-3.0</spock.version>
<stax-utils.version>20070216</stax-utils.version>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns:tx="http://www.springframework.org/schema/tx"
xmlns:context="http://www.springframework.org/schema/context"
xmlns:cache="http://www.springframework.org/schema/cache" xmlns:aop="http://www.springframework.org/schema/aop"
xmlns:cache="http://www.springframework.org/schema/cache"
xsi:schemaLocation="http://www.springframework.org/schema/beans
http://www.springframework.org/schema/beans/spring-beans.xsd
http://www.springframework.org/schema/tx
http://www.springframework.org/schema/tx/spring-tx.xsd
http://www.springframework.org/schema/context
http://www.springframework.org/schema/context/spring-context.xsd
http://www.springframework.org/schema/cache
http://www.springframework.org/schema/cache/spring-cache.xsd http://www.springframework.org/schema/aop https://www.springframework.org/schema/aop/spring-aop.xsd">
http://www.springframework.org/schema/cache/spring-cache.xsd">

<!-- TODO: this is loaded many many times on context init, which slows down startup process -->
<!-- @Transactional CAN be used on private methods with mode="aspectj". However, annotations on interfaces will NOT work! -->
Expand All @@ -21,7 +21,7 @@
<context:component-scan base-package="net.ripe.db.whois.common"/>

<context:annotation-config/>
<cache:annotation-driven mode="aspectj"/>
maggarwal13 marked this conversation as resolved.
Show resolved Hide resolved
<cache:annotation-driven/>

<!-- <aop:aspectj-autoproxy proxy-target-class="true"/>-->

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.ComponentScan;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.EnableAspectJAutoProxy;
import org.springframework.context.annotation.ImportResource;
import org.springframework.jdbc.core.JdbcTemplate;
import org.springframework.scheduling.TaskScheduler;
Expand All @@ -17,9 +18,9 @@
import javax.sql.DataSource;

@Configuration
// @EnableAspectJAutoProxy(proxyTargetClass = true)
@EnableAspectJAutoProxy(proxyTargetClass = true)
@EnableScheduling
@EnableSchedulerLock(defaultLockAtMostFor="23h", mode = AdviceMode.ASPECTJ)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also is it better to be explicit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted it to be as it was before spring upgrade.

@EnableSchedulerLock(defaultLockAtMostFor="23h")
@ImportResource(value = "classpath:applicationContext-api.xml")
@ComponentScan(basePackages="net.ripe.db.whois.scheduler")
public class SchedulerConfig {
Expand Down