Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Page improvements + minor README addition #159

Merged
merged 7 commits into from
Mar 7, 2024
Merged

Add Page improvements + minor README addition #159

merged 7 commits into from
Mar 7, 2024

Conversation

coluzziandrea
Copy link
Contributor

What

  • Added contributing link to the general README
  • Added minus sign on an expense while editing in the Add Page
  • Changed color of values in Add Page
  • Adds hint text for description

Why

It was added in the designs here

image

Screenshots & Recordings

untitled
Screenshot_1709227439
Screenshot_1709227474
Screenshot_1709227501

jackrua
jackrua reviewed Mar 2, 2024
View reviewed changes
Copy link
Contributor

@jackrua jackrua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! I got some issues here and there but I'm happy to discuss.

README.md Outdated Show resolved Hide resolved
lib/pages/add_page/add_page.dart Outdated Show resolved Hide resolved
@coluzziandrea
Copy link
Contributor Author

Thank you for your feedback @jackrua, I've added the changes you suggested!!!

@mikev-cw
Copy link
Collaborator

mikev-cw commented Mar 7, 2024

Super clear PR, and very good point addressed by @jackrua. What a pleasure, thank you both!!
Looks good to me, if also @theperu is ok with the documentation part I think we can safely merge

theperu
theperu approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@theperu theperu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@theperu theperu merged commit 184c848 into RIP-Comm:main Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackrua jackrua jackrua left review comments

@theperu theperu theperu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coluzziandrea @mikev-cw @theperu @jackrua