add python dependencies for SUIT #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic functioning of the container is checked by Travis. |
fjmolinas
requested changes
Jul 9, 2019
There was a problem hiding this comment.
I followed the testing procedure and got this error:
creating /data/riotbuild/examples/suit_update/bin/samr21-xpro/suit_update-slot0.1562671759.riot.bin...
creating /data/riotbuild/examples/suit_update/bin/samr21-xpro/suit_update-slot1.1562671759.riot.bin...
/data/riotbuild/dist/tools/suit_v4/gen_manifest.py \
--template /data/riotbuild/dist/tools/suit_v4/test-2img.json \
--urlroot coap://localhost/fw/samr21-xpro \
--seqnr 1562671759 \
--uuid-vendor "riot-os.org" \
--uuid-class samr21-xpro \
--offsets 0x1000,133120 \
-o /data/riotbuild/examples/suit_update/bin/samr21-xpro/suit_update-riot.suitv4.1562671759.bin \
/data/riotbuild/examples/suit_update/bin/samr21-xpro/suit_update-slot0.1562671759.riot.bin /data/riotbuild/examples/suit_update/bin/samr21-xpro/suit_update-slot1.1562671759.riot.bin
Traceback (most recent call last):
File "/data/riotbuild/dist/tools/suit_v4/gen_manifest.py", line 87, in <module>
main()
File "/usr/local/lib/python3.6/dist-packages/click/core.py", line 764, in __call__
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/click/core.py", line 696, in main
_verify_python3_env()
File "/usr/local/lib/python3.6/dist-packages/click/_unicodefun.py", line 124, in _verify_python3_env
' mitigation steps.' + extra
RuntimeError: Click will abort further execution because Python 3 was configured to use ASCII as encoding for the environment. Consult https://click.palletsprojects.com/en/7.x/python3/ for mitigation steps.
This system supports the C.UTF-8 locale which is recommended.
You might be able to resolve your issue by exporting the
following environment variables:
export LC_ALL=C.UTF-8
export LANG=C.UTF-8
/data/riotbuild/makefiles/suit.v4.inc.mk:64: recipe for target '/data/riotbuild/examples/suit_update/bin/samr21-xpro/suit_update-riot.suitv4.1562671759.bin' failed
make: *** [/data/riotbuild/examples/suit_update/bin/samr21-xpro/suit_update-riot.suitv4.1562671759.bin] Error 1
Doing as suggested fixed the issue.
kaspar030
force-pushed
the
add_suit_deps
branch
from
dc69b4b
to
92c8751
Compare
|
@fjmolinas is this an ACK ;) |
kaspar030
force-pushed
the
add_suit_deps
branch
from
92c8751
to
c37cc01
Compare
This has been resolved. |
fjmolinas
requested changes
Aug 9, 2019
There was a problem hiding this comment.
Since click was removed from RIOT-OS/RIOT#11818 (comment) lets remove it.
requirements.txt
Outdated
| ed25519==1.4 | ||
| cbor==1.0.0 | ||
| cryptography==2.6.1 | ||
| click==7.0 |
There was a problem hiding this comment.
This click can be removed.
There was a problem hiding this comment.
@kaspar030 seems like an easy fix ;)
so let's merge this PR the last one preliminary to #11818 ?
kaspar030
force-pushed
the
add_suit_deps
branch
from
c37cc01
to
a959d96
Compare
|
GO! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds needed dependencies for SUIT (RIOT-OS/RIOT#11818)
To test, make sure docker is correctly installed.
Then:
docker build -t riotdocker_dev .)riot (suit-pr)]$ docker run -ti --rm -v $(pwd):/data/riotbuild -u $(id -u) riotdocker_dev /bin/bashcd examples/suit_update; make suit/publishIt should succeed.
Otherwise this shouldn't affect anything, as this is only an addition of python packages.