-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flake8 dependency #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no Ubuntu package for flake8?
I looked for one but didn't find. I'll double check because now I'm not sure anymore.. |
python-flake8 from what I googled, but I guess its also fine to use pip, or not? |
I think pip is fine. I'm guessing that the package python-flake8 is for python 2.7, but I if it follows the naming conventions among the other Ubuntu packages. |
I've got an 16.04 box that offers both python-flake8 and python3-flake8. The advantage of not using pip (apart from performance reasons) is that canonical takes care of the updating, while when using pip, the docker container becomes less reproducible. IMO if there's a package, use it, so please change to use python3-flake8 |
Indeed python3-flake8 exists (just checked as well). I'll change that. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
I don't think the pep8 package was ever used. (I may have been a little trigger happy on merging that one)
&go, I'll update the murdock container. |
wait a sec please |
ok. sth wrong? |
Nope. I'm just about to provide a PR for cmake version >=3.7, because I need that for RIOT-OS/RIOT#7713 |
I meant RIOT-OS/RIOT#7437 |
Required for RIOT-OS/RIOT#8078