Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flake8 dependency #36

Merged
merged 1 commit into from
Nov 30, 2017
Merged

add flake8 dependency #36

merged 1 commit into from
Nov 30, 2017

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Nov 29, 2017

Required for RIOT-OS/RIOT#8078

Copy link
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no Ubuntu package for flake8?

@aabadie
Copy link
Contributor Author

aabadie commented Nov 29, 2017

I looked for one but didn't find. I'll double check because now I'm not sure anymore..

@smlng
Copy link
Member

smlng commented Nov 29, 2017

python-flake8 from what I googled, but I guess its also fine to use pip, or not?

@jnohlgard
Copy link
Member

I think pip is fine. I'm guessing that the package python-flake8 is for python 2.7, but I if it follows the naming conventions among the other Ubuntu packages.

@kaspar030
Copy link
Contributor

I've got an 16.04 box that offers both python-flake8 and python3-flake8.

The advantage of not using pip (apart from performance reasons) is that canonical takes care of the updating, while when using pip, the docker container becomes less reproducible.

IMO if there's a package, use it, so please change to use python3-flake8

@aabadie
Copy link
Contributor Author

aabadie commented Nov 30, 2017

Indeed python3-flake8 exists (just checked as well). I'll change that.

@aabadie
Copy link
Contributor Author

aabadie commented Nov 30, 2017

Done

Copy link
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK
I don't think the pep8 package was ever used. (I may have been a little trigger happy on merging that one)

@kaspar030
Copy link
Contributor

&go, I'll update the murdock container.

@kaspar030 kaspar030 merged commit 38f5fac into RIOT-OS:master Nov 30, 2017
@cgundogan
Copy link
Member

I'll update the murdock container.

wait a sec please

@kaspar030
Copy link
Contributor

wait a sec please

ok. sth wrong?

@cgundogan
Copy link
Member

ok. sth wrong?

Nope. I'm just about to provide a PR for cmake version >=3.7, because I need that for RIOT-OS/RIOT#7713
I figured it's easier for you to update all murdock instances only once (:

@cgundogan
Copy link
Member

I meant RIOT-OS/RIOT#7437

@aabadie aabadie deleted the flake8 branch February 27, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants