Add test for periph timer #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MichelRottleuthner can you squash please? |
MichelRottleuthner
force-pushed
the
periph_timer_test
branch
from
89de720
to
5ab0c74
Compare
smlng
requested changes
Sep 3, 2019
tests/periph_timer_cli/main.c
Outdated
| cmd_timer_bench_read }, | ||
| { "timer_init", "init_timer", cmd_timer_init }, | ||
| { "timer_set", "set timer to relative value", cmd_timer_set }, | ||
| { "timer_absolute", "set timer to absolute value", cmd_timer_absolute }, |
There was a problem hiding this comment.
should be timer_set_absolute to match (current) API
tests/periph_timer_cli/main.c
Outdated
| } | ||
|
|
||
| timer_start(timer_dev); | ||
| puts("Success: timer_start()\n"); |
There was a problem hiding this comment.
better use _print_cmd_result here too
tests/periph_timer_cli/main.c
Outdated
| } | ||
|
|
||
| timer_stop(timer_dev); | ||
| puts("Success: timer_stop()\n"); |
tests/periph_timer_cli/main.c
Outdated
|
|
||
| static gpio_t _get_pin(const char *port_str, const char *pin_str) | ||
| { | ||
| int port = _get_num(port_str); |
There was a problem hiding this comment.
error case is not checked here and below, i.e. CONVER_ERROR
tests/periph_timer_cli/main.c
Outdated
|
|
||
| if (temp == str || *temp != '\0' || | ||
| ((val == LONG_MIN || val == LONG_MAX) && errno == ERANGE)) { | ||
| val = CONVERT_ERROR; |
There was a problem hiding this comment.
the error case is not evaluated in many cases where this function is used. Maybe change to
static inline int _get_num(const char *str, uint32_t *val)
and return value by reference and error as return?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This the first few tests for periph/timer.
To make this work properly on all boards we need to provide the debug pin configuration with the environment, i.e. tell the test which pin of the DUT is connected to DEBUG0 of PHiLIP
Known issues:
The trace mechanism of PHiLIP sometimes reports timings that are not accurate.
This causes problems with the jitter test because sometimes delays around ~1.8 ms are added to the actual measurement. I verified with the scope that the timing deviation in this case actually didn't come from the DUT.
I discussed this offline with @MrKevinWeiss and we agreed that the best solution for this would be to use the capture features of the PHiLIP timer.