edbg.inc.mk: allow flashing with an offset in rom without erasing all ROM #9788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cladmi
added
CI: ready for build
This mimics openocd behaviour that only erase needed sectors of the rom.
cladmi
force-pushed
the
pr/edbg/flashbin
branch
from
d961676
to
44c3f80
Compare
Allow flashing with an offset in ROM from the rom base address. It reuses `IMAGE_OFFSET` configuration variable name from `openocd.sh`. This will allow flashing multiple images with different flash operations.
cladmi
force-pushed
the
pr/edbg/flashbin
branch
from
44c3f80
to
e6776ae
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This makes
edbg.inc.mkmore similar toopenocd.shbehavior that can flash with an offset and only erasing the needed parts of the ROM. (at least after bug fixing #9787)IMAGE_OFFFSETfor configuring rom offsetOpenocd is already not erasing the memory so not sure how "major" this is to change this default.
Testing
I do not currently have a dedicated test for this, but I will enable murdock to show it is not breaking the current tests.
We can at least see that edbg gets the correct arguments:
...
RIOT/dist/tools/edbg/edbg --offset 0x1000 -t atmel_cm0p -b -v -p -f ..../RIOT/examples/hello-world/bin/samr21-xpro/hello-world.bin
Issues/PRs references
This is part of the OTA implementation required features in #9342