-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: Add support for KEA128LEDLIGHTRD #9655
Conversation
I guess it is this board? Nice! @smlng might be interested as well. |
looks really nice, @PeterKietzmann can you order the board 😀 For the CPU (kinetis) I'd like to have @gebart opinions, too. |
Just from a quick view on this, it might be best to sort and separate this out a bit. I see 3 major contributions in this PR:
which I would pack into distinct PRs based on one-another in that order. Though the first cannot be used without the second, it still would ensure that the changes can be tested with existing kinetis CPUs. For the CAN driver I would suggest to rename it a bit and put it into |
Sure, I can break the PR into three (or four with Olimex debugger support) if you find it more convenient for review. |
By the way, what's the purpose of |
@OYTIS its more about the |
@OYTIS thanks! |
d9b3775
to
0f91e5c
Compare
|
Signed-off-by: Anton Gerasimov <[email protected]>
Signed-off-by: Anton Gerasimov <[email protected]>
@smlng Sure. Then MSCAN support on KEA128LEDLIGHTRD should come as a separate PR, right? |
yes, what I mean is: leave #9711 as is. But remove any MSCAN related config and code stuff from this PR. This might require a followup PR to enable the periph_can feature for this board later. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
The PR includes support for S9KEA128 MCU with a limited set of peripherals (LEDs, GPIOs, PIT timer and CAN) and support for the board.
I had to add some conditional compilation to kinetis codebase, because KEA family has significant differences from what was supported so far (different clock generation/distribution, different pin multiplexing).
I've also run into some issues with CAN subsystem and added some hacks to my driver as a workaround, but it's worth debugging these problems to the cause.