-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/nucleo64*: rename boards to use their ST marketing name #8649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
added
Type: enhancement
The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Area: boards
Area: Board ports
labels
Feb 27, 2018
This was referenced Feb 27, 2018
aabadie
added
Community: Hack'n'ACK candidate
This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties
and removed
Type: enhancement
The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
labels
Feb 27, 2018
aabadie
force-pushed
the
pr/nucleo-rename
branch
from
March 5, 2018 17:00
d1aa27e
to
7536700
Compare
3 tasks
I think one commit per board is enough... |
aabadie
force-pushed
the
pr/nucleo-rename
branch
2 times, most recently
from
March 13, 2018 09:01
6248523
to
386f2a5
Compare
done |
@vincent-d, rebased to fix conflicts. |
vincent-d
approved these changes
May 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
And go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: boards
Area: Board ports
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Community: Hack'n'ACK candidate
This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR renames all nucleo-64 boards to make them use the marketing name used in ST documentation, see http://www.st.com/en/evaluation-tools/stm32-mcu-nucleo.html
For the record, I used a semi-automatic renaming strategy with the following commands:
And I have a simple bash script that generates the commands.
Issues/PRs references
Partially address #8096