auto_init: fix array-initializer order for gnrc_netdev2 stacks #6312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: bug
|
could you also fix for the |
|
Fixed |
|
Rebased |
miri64
force-pushed
the
auto_init/fix/stack_array_order
branch
from
71d00d9
to
65e5fac
Compare
|
Nice catch! |
|
Would you rebase so we can also see Jeniks working? |
PeterKietzmann
added
the
CI: ready for build
miri64
force-pushed
the
auto_init/fix/stack_array_order
branch
from
65e5fac
to
a4d421a
Compare
|
Rebased. |
|
@miri64 please squash |
miri64
force-pushed
the
auto_init/fix/stack_array_order
branch
from
a4d421a
to
82d8d3d
Compare
done |
|
@haukepetersen your review was requested. Changes were addressed and Murdock/Jenkins succeeded. Pleas merge! |
|
Anyone willing to ACK? |
|
and go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #6311 I noticed, that quite a few stacks arrays for the gnrc_netdev2 auto-initialization have their initializers switched around. This leads to faulty code, since apart from a few byte all threads will have the same stack (and TCB) which leads to funny errors, like only the last initialized thread answering to IPC messages of all devices of that type.