Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/sys/events: test if event_timeout_is_pending returns false #21032

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

JulianHolzwarth
Copy link
Contributor

Contribution description

This change edits the /sys/events/ test to test if event_timeout_is_pending returns false when event_timeout_t is not completely initialized. Meaning when event_timeout_t ->queue, event_timeout_t ->clock or event_timeout_t ->event is NULL event_timeout_is_pending should return false.
This was previously not tested.

Testing procedure

BOARD=native make -C tests/sys/events flash test

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Nov 22, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 22, 2024
@riot-ci
Copy link

riot-ci commented Nov 22, 2024

Murdock results

✔️ PASSED

83cf6bf tests/sys/events/: test if event_timeout_is_pending returns false

Success Failures Total Runtime
20 0 22 01m:33s

Artifacts

Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a minor suggestion below.

tests/sys/events/main.c Outdated Show resolved Hide resolved
@mguetschow mguetschow changed the title tests/sys/events/: test if event_timeout_is_pending returns false tests/sys/events: test if event_timeout_is_pending returns false Nov 25, 2024
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please squash :)

test if event_timeout_is_pending returns false when event_timeout_t is not completly initialized
@JulianHolzwarth
Copy link
Contributor Author

Squashed and all checks passed.

@mguetschow mguetschow added this pull request to the merge queue Nov 25, 2024
Merged via the queue into RIOT-OS:master with commit e9e946d Nov 26, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants