core/thread: "fix" valgrind errors in thread_measure_stack_free() #20726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
the
State: waiting for other PR
maribu
requested review from
leandrolanzieri,
aabadie,
MichelRottleuthner and
kaspar030
as code owners
github-actions
bot
added
Area: tests
benpicco
reviewed
Jun 5, 2024
benpicco
removed
the
State: waiting for other PR
The dark magic used used in thread_measure_stack_free() is frowned upon by valgrind. E.g. valgrind may deduce (by monitoring the stack pointer) that a specific value was at some point allocated on the stack, but has gone out of scope. When that value is now read again to estimate stack usage, it does look a lot like someone passed a pointer to a stack allocated value, and that pointer is referenced after that value has gone out of scope. This is "fixed" by temporarily disabling valgrind error reporting while iterating over the stack.
maribu
force-pushed
the
core/thread/valgrind-disable
branch
from
e1d61ae
to
11e273c
Compare
benpicco
approved these changes
Jun 5, 2024
benpicco
added
the
CI: ready for build
|
Thx :) |
maribu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The dark magic used used in thread_measure_stack_free() is frowned upon by valgrind. E.g. valgrind may deduce (by monitoring the stack pointer) that a specific value was at some point allocated on the stack, but has gone out of scope. When that value is now read again to estimate stack
usage, it does look a lot like someone passed a pointer to a stack allocated value, and that pointer is referenced after that value has gone out of scope.
This is "fixed" by temporarily disabling valgrind error reporting while iterating over the stack.
Testing procedure
Testing that this indeed "fixes" the warning
With this PR:
With #20723 (with current
masterthe function is broken and doesn't iterate over the stack - hence, no errors):(That one context is
thread_measure_stack_free().)Confirming that suppression is reasonable
Double check my reasoning why, in this specific instance, the access of stack memory is not an error.
Issues/PRs references
Depends upon and includes: