Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/wamr: updated package to WAMR 1.3.3 #20691

Merged
merged 1 commit into from
May 23, 2024
Merged

pkg/wamr: updated package to WAMR 1.3.3 #20691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/wamr/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
PKG_NAME=wamr
PKG_URL=https://github.com/bytecodealliance/wasm-micro-runtime.git
ifeq ($(PKG_BLEADING),1)
ifeq ($(PKG_BLEEDING),1)
PKG_VERSION=main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this doesn't work, you can just drop it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does work for me ( just tested)

$ cd <RIOT>/examples/wasm
$ PKG_BLEADING=1 make 
$ cd  <RIOT>/build/pkg/wamr 
$ git status 
On branch main
Your branch is up to date with 'origin/main'.

$ cd <RIOT>/examples/wasm
$ make 
$ cd  <RIOT>/build/pkg/wamr 
$ git status 
HEAD detached at dc4dcc3

Copy link
Contributor

@kfessel kfessel May 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching the typo

Sadly this currently the only package to support a instantaneous test with the current upstream main branch.

The PKG_VERSION= supports hashes, tags, and branches main is a branch.

We usually only use hashes because everything else can change, and we might have to do much work to keep track especially if projects change API, or we apply patches. At least the patches are very avoidable with wamr, since the upstream is very responsive.

else
PKG_VERSION=dc4dcc3d6fba42dbe93cf9050fad8e0cfa4b88d0
#release tag: WAMR-1.1.1
PKG_VERSION=3f5e2bd23bcb8eb3767c8e17789c6a2e3e912a08
#release tag: WAMR-1.3.3
endif
PKG_LICENSE=Apache-2.0

Expand Down
Loading