-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile.{include,base},pkg/nanopb: fix target deps & code generation #20400
Merged
benpicco
merged 1 commit into
RIOT-OS:master
from
ML-PA-Consulting-GmbH:dl/fix/20240219_nanopb_code_generation
Mar 12, 2024
Merged
Makefile.{include,base},pkg/nanopb: fix target deps & code generation #20400
benpicco
merged 1 commit into
RIOT-OS:master
from
ML-PA-Consulting-GmbH:dl/fix/20240219_nanopb_code_generation
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: build system
Area: Build system
Area: pkg
Area: External package ports
labels
Feb 19, 2024
benpicco
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Feb 19, 2024
benpicco
reviewed
Feb 19, 2024
benpicco
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash
DanielLockau-MLPA
force-pushed
the
dl/fix/20240219_nanopb_code_generation
branch
from
March 12, 2024 08:53
9c44697
to
9c9d739
Compare
benpicco
reviewed
Apr 5, 2024
@@ -2,29 +2,40 @@ PROTOC ?= protoc | |||
PROTOC_GEN_NANOPB ?= $(PKGDIRBASE)/nanopb/generator/protoc-gen-nanopb | |||
|
|||
PROTOBUF_FILES ?= $(wildcard *.proto) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our branch we have
Suggested change
PROTOBUF_FILES ?= $(wildcard *.proto) | |
PROTOBUF_FILES += $(wildcard *.proto) |
and apps that don't build with the upstream version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: build system
Area: Build system
Area: pkg
Area: External package ports
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR aims to
To achieve that
Testing procedure
none
Issues/PRs references
none