cpu/native: fix native_async_read_remove_handler() + enable all baudrates #20368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Platform: native
derMihai
commented
Feb 10, 2024
| @@ -135,7 +135,6 @@ int uart_init(uart_t uart, uint32_t baudrate, uart_rx_cb_t rx_cb, void *arg) | |||
| case 57600: speed = B57600; break; | |||
| case 115200: speed = B115200; break; | |||
| case 230400: speed = B230400; break; | |||
| #if __linux__ | |||
There was a problem hiding this comment.
Some of these baudrates were already included unconditionally (e.g. 115200) so I think it's safe to assume they are available everywhere.
benpicco
added
Impact: minor
benpicco
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Fix previous PR.
Issues/PRs references
#20365