Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/suit: introduce suit_worker_done_cb() #20237

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Jan 8, 2024

Contribution description

This makes the SUIT worker a bit more flexible: Currently the board will always reboot after the update process, there is no way for the application to tell whether the update was successful.

This patch moves the 'reboot after update' policy to a suit_worker_done_cb() function that can be overwritten by custom application logic.

Testing procedure

No change in default behavior.

Issues/PRs references

@github-actions github-actions bot added Area: OTA Area: Over-the-air updates Area: sys Area: System labels Jan 8, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 8, 2024
@benpicco benpicco requested a review from maribu January 8, 2024 19:43
@riot-ci
Copy link

riot-ci commented Jan 8, 2024

Murdock results

✔️ PASSED

7c9345f sys/suit: introduce suit_worker_done_cb()

Success Failures Total Runtime
8085 0 8085 12m:35s

Artifacts

@benpicco benpicco added this pull request to the merge queue Jan 9, 2024
Merged via the queue into RIOT-OS:master with commit 45bc3bb Jan 9, 2024
29 checks passed
@benpicco benpicco deleted the suit_worker_done_cb branch January 9, 2024 10:59
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OTA Area: Over-the-air updates Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants