Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/build_system/test_tools: use native terminal #20212

Merged
merged 1 commit into from
Dec 22, 2023
Merged

tests/build_system/test_tools: use native terminal #20212

merged 1 commit into from
Dec 22, 2023

Conversation

benpicco
Copy link
Contributor

Contribution description

The test appears to expect the 'classic' native output.

Testing procedure

CI should work again.

Issues/PRs references

#20172

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Dec 22, 2023
@benpicco benpicco added Area: build system Area: Build system Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: no fast fail don't abort PR build after first error labels Dec 22, 2023
@riot-ci
Copy link

riot-ci commented Dec 22, 2023 •
edited
Loading

Murdock results

✔️ PASSED

90dad75 tests/build_system/test_tools: use native terminal

Success Failures Total Runtime
138134 0 138134 02h:33m:48s

Artifacts

@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: full build disable CI build filter and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 22, 2023
OlegHahm
OlegHahm approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@OlegHahm OlegHahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what exactly is broken - but it definitely make sense to run tests without pyterm.

@benpicco benpicco added this pull request to the merge queue Dec 22, 2023
Merged via the queue into RIOT-OS:master with commit 5898c80 Dec 22, 2023
36 checks passed
@benpicco benpicco deleted the pyterm_native-fixes branch December 22, 2023 20:20
@benpicco benpicco mentioned this pull request Dec 22, 2023
Closed
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegHahm OlegHahm OlegHahm approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: tests Area: tests and testing framework CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: full build disable CI build filter CI: no fast fail don't abort PR build after first error CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Milestone
Release 2024.01
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @OlegHahm @MrKevinWeiss