Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/nrf9160dk: use all available CC timer channels #19771

Merged
merged 1 commit into from
Jul 4, 2023
Merged

boards/nrf9160dk: use all available CC timer channels #19771

merged 1 commit into from
Jul 4, 2023

Conversation

dylad
Copy link
Member

@dylad dylad commented Jun 28, 2023

Contribution description

nRF9160 has 6 CC per timer.
You can grep -ra "CC_NUM" cpu/nrf9160 to check it.
So let's use all available CC.

Testing procedure

You can run tests/periph/timer to see the new CC.

Issues/PRs references

None.

@github-actions github-actions bot added the Area: boards Area: Board ports label Jun 28, 2023
@dylad dylad added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 28, 2023
@riot-ci
Copy link

riot-ci commented Jun 28, 2023 •
edited
Loading

Murdock results

✔️ PASSED

ff076fa boards/nrf9160dk: use all available CC timer channels

Success Failures Total Runtime
500 0 500 03m:41s

Artifacts

maribu
maribu approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I once broke a board config by adding all available CC timer channels here because I failed to notice that one is used to implement timer_read(). It would be nice if you could add a comment to prevent others from doing the same mistake.

I'm not insisting, though. If you agree, please squash at will and feel free to kick bors.

boards/nrf9160dk/include/periph_conf.h Show resolved Hide resolved
boards/nrf9160dk/include/periph_conf.h Show resolved Hide resolved
@dylad dylad force-pushed the boards/nrf9160dk/timer_cc_numof branch from 6b7b76f to ff076fa Compare July 4, 2023 11:59
@dylad
Copy link
Member Author

dylad commented Jul 4, 2023

Comment added :)

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 4, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@bors
Copy link
Contributor

bors bot commented Jul 4, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit e0361ab into RIOT-OS:master Jul 4, 2023
@dylad
Copy link
Member Author

dylad commented Jul 4, 2023

Thanks for the review !

@dylad dylad deleted the boards/nrf9160dk/timer_cc_numof branch July 4, 2023 12:34
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

Assignees
No one assigned
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.
4 participants
@dylad @riot-ci @maribu @benpicco