boards: Fix I2C Arduino mapping #19767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct macro name is `ARDUINO_I2C_UNO` for Arduino UNO compatible I2C bus location, or `ARDUINO_I2C_NANO` for Arduino Nano compatible I2C bus location.
maribu
added
Type: bug
github-actions
bot
added
Area: boards
Teufelchen1
approved these changes
Jun 28, 2023
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
Thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The correct macro name is
ARDUINO_I2C_UNOfor Arduino UNO compatible I2C bus location, orARDUINO_I2C_NANOfor Arduino Nano compatible I2C bus location. Hence, rename it fromARDUINI_I2C0to the correct name.Testing procedure
Check the documentation at https://doc.riot-os.org/iomaps.html#iomaps-mapping-i2c and confirm:
The I2C bus macros should indeed be named
ARDUINO_I2C_UNO(when compatible with shields targeting the Arduino UNO R3) orARDUINO_I2C_NANO(when compatible with shields targeting the Arduino Nano).Issues/PRs references
Introduced by #19759