Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/posix/sockets: fix code style & set sin6_scope_id in _ep_to_sockaddr() #19658

Merged
merged 2 commits into from
May 24, 2023

Conversation

maribu
Copy link
Member

@maribu maribu commented May 23, 2023

Contribution description

  • Fix double indent of switch cases to single indent, as per coding convention. (Whitespace only change.)
  • Set sin6_scope_id to netif in _ep_to_sockaddr()

Testing procedure

  • Check the first commit indeed is a whitespace only change
    • except for an assert(0) added to the default: case of a switch replacing an assert((ep->family == AF_INET) || (ep->family == AF_INET6)); before the switch(ep->family). But this does the same, while being more readable.
  • Review the second commit (a one-liner)

Issues/PRs references

Fixes #19486

Fix double indent of switch cases to single indent, as per coding
convention.
@github-actions github-actions bot added the Area: sys Area: System label May 23, 2023
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 23, 2023
@benpicco benpicco requested a review from miri64 May 23, 2023 20:40
@riot-ci
Copy link

riot-ci commented May 23, 2023

Murdock results

✔️ PASSED

77afc5e sys/posix/sockets: set sin6_scope_id in _ep_to_sockaddr()

Success Failures Total Runtime
6933 0 6933 11m:30s

Artifacts

@benpicco
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented May 24, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit e93d597 into RIOT-OS:master May 24, 2023
@maribu maribu deleted the issue-19486 branch May 24, 2023 19:07
@maribu
Copy link
Member Author

maribu commented May 24, 2023

Thx :)

@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: _ep_to_sockaddr() does not update in6_addr->sin6_scope_id
3 participants