Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix periph clk #19628

Merged
merged 2 commits into from
May 21, 2023
Merged

Fix periph clk #19628

merged 2 commits into from
May 21, 2023

Conversation

Enoch247
Copy link
Contributor

Contribution description

This fixes some minor doc and argument type errors. See commit messages for details.

Testing procedure

It compiles without errors for me.

Issues/PRs references

None known

The doxygen doc for `periph_lpclk_dis()` and `periph_clk_dis()` we
flip-flopped. This patch corrects this.
Some periph clock functions took the bus arg as a `uin8_t`, others took
it as a `bus_t`. This patch makes them all take it as a `bus_t`.
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ARM Platform: This PR/issue effects ARM-based platforms labels May 19, 2023
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 20, 2023
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@riot-ci
Copy link

riot-ci commented May 20, 2023

Murdock results

✔️ PASSED

094977d cpu/stm32: make bus arg consistent

Success Failures Total Runtime
6945 0 6946 09m:32s

Artifacts

@aabadie
Copy link
Contributor

aabadie commented May 21, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented May 21, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit a28f6e5 into RIOT-OS:master May 21, 2023
@Enoch247 Enoch247 deleted the fix-periph-clk branch May 23, 2023 16:06
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants