Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/esp32: fix remaining compilation errors for GCC 12.2 #19577

Merged
merged 3 commits into from
May 11, 2023
Merged

cpu/esp32: fix remaining compilation errors for GCC 12.2 #19577

merged 3 commits into from
May 11, 2023

Conversation

gschorcht
Copy link
Contributor

@gschorcht gschorcht commented May 10, 2023 •
edited
Loading

Contribution description

This PR fixes one problem of CI compilation.

With PR #227 riotdocker was updated to GCC 12.2 . Obviously, following parts were not covered by compilation test before:

  • esp_eth
  • esp_hw_counter
  • esp_can

Testing procedure

Issues/PRs references

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms labels May 10, 2023
@gschorcht gschorcht added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 10, 2023
@gschorcht
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 10, 2023
@bors
Try #19577:
04aae92
@riot-ci
Copy link

riot-ci commented May 10, 2023 •
edited
Loading

Murdock results

✔️ PASSED

85f7d8b cpu/esp32: fix compilation of esp_can

Success Failures Total Runtime
6931 0 6931 10m:12s

Artifacts

@bors
Copy link
Contributor

bors bot commented May 10, 2023

try

Build failed:

@gschorcht gschorcht changed the title cpu/esp32: fix compilation errors in esp_eth cpu/esp32: fix remaining compilation errors for GCC 12.2 May 10, 2023
@gschorcht
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 10, 2023
@bors
Try #19577:
926d508
@bors
Copy link
Contributor

bors bot commented May 11, 2023

try

Build failed:

@maribu maribu mentioned this pull request May 11, 2023
Merged
@gschorcht gschorcht force-pushed the cpu/esp32/fix_remaining_compilation_problems_gcc_12_2 branch from 73f805a to 85f7d8b Compare May 11, 2023 05:23
@gschorcht
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 11, 2023
@bors
Try #19577:
77a5683
@maribu
Copy link
Member

maribu commented May 11, 2023

bors cancel
bors merge

@bors
Copy link
Contributor

bors bot commented May 11, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

bors bot added a commit that referenced this pull request May 11, 2023
@bors @gschorcht
Merge #19577
cae9203 
19577: cpu/esp32: fix remaining compilation errors for GCC 12.2 r=maribu a=gschorcht

### Contribution description

This PR fixes one problem of CI compilation.

With [PR #227](RIOT-OS/riotdocker#227) `riotdocker` was updated to GCC 12.2 . Obviously, following parts were not covered by compilation test before:

- [ ] `esp_eth`
- [ ] `esp_hw_counter`
- [ ] `esp_can`

### Testing procedure

### Issues/PRs references


Co-authored-by: Gunar Schorcht <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 11, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@maribu maribu added the CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs label May 11, 2023
@maribu
Copy link
Member

maribu commented May 11, 2023

bors cancel
bors merge

(No other PR has been merged since the try, so no need to another full CI loop.)

@bors
Copy link
Contributor

bors bot commented May 11, 2023

Canceled.

@bors
Copy link
Contributor

bors bot commented May 11, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 0a7bc1a into RIOT-OS:master May 11, 2023
@gschorcht
Copy link
Contributor Author

Thanks, CI should now work with GCC 12.2 for ESP32x.

@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
@gschorcht gschorcht deleted the cpu/esp32/fix_remaining_compilation_problems_gcc_12_2 branch September 10, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Platform: ESP Platform: This PR/issue effects ESP-based platforms
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.
4 participants
@gschorcht @riot-ci @maribu @benpicco