tests/periph_rtt: Fix for tick conversion test #19522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chudov
requested review from
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
benpicco
added
CI: ready for build
benpicco
reviewed
May 2, 2023
chudov
force-pushed
the
tests/periph_rtt_avr_rfr2_fix
branch
from
78f3fb7
to
6c94491
Compare
|
@benpicco is it better now? |
|
Yes, thank you! |
benpicco
reviewed
May 2, 2023
benpicco
reviewed
May 2, 2023
chudov
force-pushed
the
tests/periph_rtt_avr_rfr2_fix
branch
from
6c94491
to
7c3186d
Compare
chudov
force-pushed
the
tests/periph_rtt_avr_rfr2_fix
branch
from
7c3186d
to
a6ad25c
Compare
Signed-off-by: chudov <[email protected]>
chudov
force-pushed
the
tests/periph_rtt_avr_rfr2_fix
branch
from
a6ad25c
to
8803944
Compare
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Type casting and
printfformatting for theRTT_MAX_VALUEandRTT_FREQUENCYare fixed so 32-bit value is properly handled by 'avr-libc'.The original tick conversion test assumes that
RTT_FREQUENCYis power of 2 so forward and backward ticks to seconds conversion results in the original ticks value. To fix it the result of the forward-backward conversion is compared withticktest / RTT_FREQUENCY * RTT_FREQUENCYthat considers rounding errors.Changes were tested on deRFmega256 and nrf52840dongle.
Testing procedure
tests/periph_rtt on a board with ATmega256RFR2 shall:
Issues/PRs references
Fixes #15940