Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/esp32c3-wemos-mini: add support for Wemos ESP32-C3 mini #19417

Merged
merged 1 commit into from
Mar 30, 2023
Merged

boards/esp32c3-wemos-mini: add support for Wemos ESP32-C3 mini #19417

merged 1 commit into from
Mar 30, 2023

Conversation

gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Mar 23, 2023 •
edited
Loading

Contribution description

This PR provides the support for the Wemos ESP32-C3 mini board.

Testing procedure

The board should work for provided features.

The board was already tested with:

  • tests/driver_sht3x using I2C
  • tests/driver_l3gxxxx using SPI
  • tests/periph_adc
  • tests/periph_pwm
  • tests/driver_ws281x

Issues/PRs references

@github-actions github-actions bot added Area: boards Area: Board ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration labels Mar 23, 2023
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Mar 23, 2023
@riot-ci
Copy link

riot-ci commented Mar 23, 2023 •
edited
Loading

Murdock results

✔️ PASSED

79fc49c boards/esp32c3-wemos-mini: add support for Wemos ESP32-C3 mini

Success Failures Total Runtime
514 0 514 03m:34s

Artifacts

@gschorcht gschorcht force-pushed the boards/esp32c3-wemos-mini branch 2 times, most recently from 80d091e to c13fdd2 Compare March 23, 2023 14:08
benpicco
benpicco reviewed Mar 24, 2023
View reviewed changes
boards/esp32c3-wemos-mini/Kconfig Outdated
config MODULE_ESP32C3_WEMOS_MINI_V2_1_0
bool
help
Indicates that Wemos ESP32-C3 mini board version v2.0.0 is used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Indicates that Wemos ESP32-C3 mini board version v2.0.0 is used.
Indicates that Wemos ESP32-C3 mini board version v2.1.0 is used.

?

How do the versions differ/how can the user tell which is which?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versions differ

  • in their pinout for GPIO0 ... GPIO6 which in turn affects the pins used for ADC channels and even more important for SPI and
  • in what type of LED (RGB LED vs. LED) they have connected to GPIO7.

To ensure the right assignment of SPI signals, the board version has to be specified either using USEMODULE=esp32c3-wemos-mini_v*_*_0 in make or the choice of the MODULE_ESP32C3_WEMOS_MINI_V*_*_0 symbols in Kconfig.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the RGB led is a good sign, we can add that to the description of the option.

boards/esp32c3-wemos-mini/Makefile.include Outdated
Comment on lines 6 to 11
# default board version if not defined
#BOARD_VERSION ?= esp32c3_wemos_mini_v2_1_0

#ifndef CONFIG_USB_VID
# CFLAGS += -DCONFIG_BOARD_VERSION_$(call uppercase_and_underscore,$(BOARD_VERSION))
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's just a leftover. Before I used pseudomodules esp32c3_wemos_mini_v2_1_0 and esp32c3_wemos_mini_v1_0_0 I tried to realize the version handling by variable BOARD_VERSION.

boards/esp32c3-wemos-mini/include/arduino_board.h Show resolved Hide resolved
boards/esp32c3-wemos-mini/include/gpio_params.h Show resolved Hide resolved
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Mar 28, 2023
@github-actions github-actions bot removed Platform: ESP Platform: This PR/issue effects ESP-based platforms Area: cpu Area: CPU/MCU ports labels Mar 29, 2023
@gschorcht
Copy link
Contributor Author

@benpicco Is there anything else for this board to change?

@benpicco
Copy link
Contributor

No, just the remaining open comments, you can directly squash.

@gschorcht
Copy link
Contributor Author

Ok, fixed.

@benpicco
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 30, 2023

Build succeeded:

@bors bors bot merged commit a7c857d into RIOT-OS:master Mar 30, 2023
@gschorcht
Copy link
Contributor Author

@benpicco Thanks

@gschorcht gschorcht deleted the boards/esp32c3-wemos-mini branch March 30, 2023 22:26
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
4 participants
@gschorcht @riot-ci @benpicco @MrKevinWeiss