dist/tools/insufficient_memory: Minor improvements #19303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
Impact: minor
benpicco
approved these changes
Feb 23, 2023
benpicco
added
CI: ready for build
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Feb 23, 2023
19303: dist/tools/insufficient_memory: Minor improvements r=maribu a=maribu ### Contribution description - address all shellcheck warnings - make script POSIX shell compatible - use nproc to set the number of parallel jobs to increase throughput - print error messages when building fails - run `make info-boards-supported` with `EXTERNAL_BOARD_DIRS=""` to avoid adding out-of-tree boards to `Makefile.ci`. ### Testing procedure Run the script; it should still work. ### Issues/PRs references None Co-authored-by: Marian Buschsieweke <[email protected]>
maribu
commented
Feb 23, 2023
|
bors cancel |
|
Canceled. |
maribu
force-pushed
the
dist/tools/insufficient_memory/create_makefile.ci.sh
branch
from
e804706
to
db106f8
Compare
maribu
force-pushed
the
dist/tools/insufficient_memory/create_makefile.ci.sh
branch
2 times, most recently
from
508fd4d
to
a779fd0
Compare
|
Sorry, I forgot to also classify as |
maribu
force-pushed
the
dist/tools/insufficient_memory/create_makefile.ci.sh
branch
from
a779fd0
to
72bf076
Compare
|
Another instance of missing |
`create_makefile.sh`: - address all shellcheck warnings - make script POSIX shell compatible - use nproc to set the number of parallel jobs to increase throughput - print error messages when building fails - run `make info-boards-supported` with `EXTERNAL_BOARD_DIRS=""` to avoid adding out-of-tree boards to `Makefile.ci`. - classify output as "not supported" also when used features are blacklisted, not only when required features are missing - classify output as "not supported' also when output contains `not supported. Stop.`, e.g. as raised by pkg/tinyusb on unsupported CPUs / CPU families. `add_insufficient_memory_board.sh`: - classify output as "not supported" also when used features are blacklisted, not only when required features are missing - classify output as "not supported' also when output contains `not supported. Stop.`, e.g. as raised by pkg/tinyusb on unsupported CPUs / CPU families.
maribu
force-pushed
the
dist/tools/insufficient_memory/create_makefile.ci.sh
branch
from
72bf076
to
fe176f5
Compare
|
OK, looks like I have won this game of whack a mole this time :) Should now be ready for review |
|
bors merge |
|
Build succeeded: |
maribu
deleted the
dist/tools/insufficient_memory/create_makefile.ci.sh
branch
|
Thx :) |
benpicco
reviewed
Mar 16, 2023
|
|
||
| for BOARD in $(make --no-print-directory info-boards-supported -C "${APP_DIR}"); do | ||
| for BOARD in $(EXTERNAL_BOARD_DIRS="" make --no-print-directory info-boards-supported -C "${APP_DIR}"); do |
There was a problem hiding this comment.
hm for some reason this does not work, my list of EXTERNAL_BOARD_DIRS still gets iterated.
What works is doing
EXTERNAL_BOARD_DIRS= make generate-Makefile.ci
but that's easily forgotten and we end up with internal boards in Makefile.ci
There was a problem hiding this comment.
Suggested change
| for BOARD in $(EXTERNAL_BOARD_DIRS="" make --no-print-directory info-boards-supported -C "${APP_DIR}"); do | |
| for BOARD in $(make EXTERNAL_BOARD_DIRS="" --no-print-directory info-boards-supported -C "${APP_DIR}"); do |
Could you give this a try?
There was a problem hiding this comment.
nope that doesn't make a difference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
create_makefile.sh:make info-boards-supportedwithEXTERNAL_BOARD_DIRS=""to avoid adding out-of-tree boards toMakefile.ci.add_insufficient_memory_board.sh:Testing procedure
Run the script; it should still work.
Issues/PRs references
None