cpu/esp_common: use generic WIFI_SSID/WIFI_PASS defines #19286

benpicco · 2023-02-17T14:21:17Z

Contribution description

Writing generic applications that work with both esp_wifi and atwinc15x0 is hampered by the different names for the SSID/Password defines.

esp_wifi uses ESP_WIFI_SSID while atwinc15x0 uses the more generic WIFI_SSID.

Also use the generic name for esp_wifi.

Testing procedure

Connecting to a WiFi AP should still work.

Issues/PRs references

riot-ci · 2023-02-17T14:43:52Z

Murdock results

✔️ PASSED

cebd768 cpu/esp_common: rename ESP_WIFI_EAP_* -> WIFI_EAP_*

Success	Failures	Total	Runtime
6864	0	6865	10m:45s

Artifacts

Documentation preview

maribu · 2023-02-17T14:57:47Z

bors merge

cpu/esp32/doc.txt

cpu/esp_common/esp-wifi/doc.txt

19286: cpu/esp_common: use generic WIFI_SSID/WIFI_PASS defines r=maribu a=benpicco Co-authored-by: Benjamin Valentin <[email protected]>

gschorcht · 2023-02-17T15:01:45Z

Thank you for this PR, I had this gernalization on my ToDo for a long time. I would like also to generalize the WPA2 Enterprise configurations.

maribu · 2023-02-17T15:03:06Z

bors cancel

bors · 2023-02-17T15:03:08Z

Canceled.

benpicco · 2023-02-17T15:10:24Z

I would like also to generalize the WPA2 Enterprise configurations.

sure, added

gschorcht · 2023-02-17T15:38:02Z

Since we have been using the ESP_WIFI_* definitions in RIOT for the last 4 years and have not marked them as deprecated yet, we should add some default settings for changed configurations like

#if !defined(WIFI_SSID) and defined(ESP_WIFI_SSID)
#define WIFI_SSID ESP_WIFI_SSID
#endif

At least we should add something like

#if defined(ESP_WIFI_SSID)
#warning "ESP_WIFI_SSID is obsolete, please use WIFI_SSID instead"
#endif

benpicco · 2023-02-17T15:44:15Z

cpu/esp_common/esp-wifi/esp_wifi_params.h

-#define ESP_WIFI_SSID       "RIOT_AP"
+#ifndef WIFI_SSID
+#ifdef ESP_WIFI_SSID
+#define WIFI_SSID           ESP_WIFI_SSID


Already done here

benpicco · 2023-02-17T15:44:22Z

cpu/esp_common/esp-wifi/esp_wifi_params.h

+#endif
+
+#if !defined(WIFI_PASS) && defined(ESP_WIFI_PASS)
+#define WIFI_PASS           ESP_WIFI_PASS


cpu/esp_common/esp-wifi/esp_wifi_netdev.c

gschorcht · 2023-02-17T15:58:58Z

Please squash.

gschorcht · 2023-02-17T16:11:35Z

bors merge

bors · 2023-02-17T16:11:49Z

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

benpicco · 2023-02-17T16:34:48Z

bors merge

19027: sys/fmt: optimize scn_u32_dec scn_u32_hex r=benpicco a=kfessel ### Contribution description Improves the compilation result for `scn_u32_dec` `scn_u32_hex` especially on `cortex-m` reducing either stack usage and or code size. This makes use of unsigned int overflow (slightly less better without doing that `hexn`). See godbolt (original versions got an `o` attached, modified versions got `k`s) all functions are marked `_S_` defined to `static` by assigning the global at end the compiled function can be changed (`deco deck hexo hexk hexkk hexn`) this PR is `hexkk` and `deck` ### Testing procedure run unit-test/test-fmt ``` <RIOT>/tests/unittests$ make tests-fmt <RIOT>/tests/unittests$ make term ``` ### Issues/PRs references [godbolt](https://godbolt.org/z/MzT1zh4q1) 19256: pkg/tinyusb: add GD32VF103 support r=benpicco a=gschorcht ### Contribution description This PR provides the tinyUSB support for GD32VF103 and enables the `tinyusb_device` feature as well as `stdio_tinyusb_cdc_acm` for GD32VF103 boards. ### Testing procedure ``` BOARD=sipeeed-longan-nano make -C tests/shell flash term ``` should work ### Issues/PRs references 19269: cpu/gd32v/periph_i2c: interrupt based driver r=benpicco a=gschorcht ### Contribution description This PR provides an interrupt-driven version of the I2C low-level driver. The existing I2C low-level driver for GDVF103 uses a busy-waiting approach where the status register is continuously polled while waiting for a certain status when sending or receiving. The MCU is thus occupied the whole time during a send or receive operation. The driver provided with this PR uses an interrupt-driven approach. This is, while waiting for a certain status when sending or receiving, the calling thread is suspended and woken up by interrupts. Since the I2C controller allows to receive up to two bytes before the application has to react, receiving a single byte, two bytes or more than two bytes needs a different handling for correct receiption. This requires a tricky implementation which distinguish a number of different case. There the driver requires 860 byte more ROM and 8 byte more RAM. ### Testing procedure The driver should work with any I2C sensor/actuator. It was tested with - `tests/driver_bmp180` <details> ``` main(): This is RIOT! (Version: 2023.04-devel-355-g940c7-cpu/gd32v/periph_i2c_interrupt_driven) BMP180 test application +------------Initializing------------+ Initialization successful +------------Calibration------------+ AC1: 8448 AC2: -1208 AC3: -14907 AC4: 33310 AC5: 24774 AC6: 19213 B1: 6515 B2: 49 MB: -32768 MC: -11786 MD: 2958 +--------Starting Measurements--------+ Temperature [°C]: 22.0 Pressure [hPa]: 1006.49 Pressure at see level [hPa]: 1025.55 Altitude [m]: 157 +-------------------------------------+ Temperature [°C]: 22.0 Pressure [hPa]: 1006.56 Pressure at see level [hPa]: 1025.58 Altitude [m]: 157 +-------------------------------------+ ``` </details> - `tests/driver_ccs811` <details> ``` main(): This is RIOT! (Version: 2023.04-devel-355-g940c7-cpu/gd32v/periph_i2c_interrupt_driven) CCS811 test application +------------Initializing------------+ +--------Starting Measurements--------+ TVOC [ppb]: 0 eCO2 [ppm]: 0 +-------------------------------------+ TVOC [ppb]: 0 eCO2 [ppm]: 0 +-------------------------------------+ TVOC [ppb]: 0 eCO2 [ppm]: 0 +-------------------------------------+ TVOC [ppb]: 0 eCO2 [ppm]: 400 +-------------------------------------+ TVOC [ppb]: 0 eCO2 [ppm]: 400 +-------------------------------------+ TVOC [ppb]: 0 eCO2 [ppm]: 400 +-------------------------------------+ TVOC [ppb]: 7 eCO2 [ppm]: 446 +-------------------------------------+ TVOC [ppb]: 7 eCO2 [ppm]: 446 +-------------------------------------+ TVOC [ppb]: 7 eCO2 [ppm]: 446 +-------------------------------------+ TVOC [ppb]: 7 eCO2 [ppm]: 446 +-------------------------------------+ ``` </details> - `tests/driver_sht3x` <details> ``` main(): This is RIOT! (Version: 2023.04-devel-355-g940c7-cpu/gd32v/periph_i2c_interrupt_driven) SHT3X test application +------------Initializing------------+ Initialization successful +--------Starting Measurements--------+ Temperature [°C]: 21.46 Relative Humidity [%]: 54.50 +-------------------------------------+ Temperature [°C]: 21.47 Relative Humidity [%]: 54.53 +-------------------------------------+ Temperature [°C]: 21.46 Relative Humidity [%]: 54.48 +-------------------------------------+ Temperature [°C]: 21.46 Relative Humidity [%]: 54.47 +-------------------------------------+ ``` </details> - `tests/driver_l3gxxxx` <details> ``` main(): This is RIOT! (Version: 2023.04-devel-375-g75547-cpu/gd32v/periph_i2c_interrupt_driven) L3GXXXX gyroscope driver test application Initializing L3GXXXX sensor [OK] gyro [dps] x: +0, y: -1, z: -2 gyro [dps] x: +0, y: +0, z: +0 gyro [dps] x: +0, y: +0, z: +0 gyro [dps] x: +0, y: +0, z: +0 gyro [dps] x: +0, y: +0, z: +0 gyro [dps] x: +0, y: +0, z: +0 gyro [dps] x: -1, y: +0, z: +4 gyro [dps] x: +0, y: +0, z: -21 gyro [dps] x: +0, y: +0, z: +6 gyro [dps] x: -43, y: +0, z: -13 gyro [dps] x: -21, y: -2, z: +0 gyro [dps] x: +0, y: +1, z: +3 gyro [dps] x: +25, y: +0, z: +0 ``` </details> - `tests/driver_hd44780` with `pcf8574a` I2C interface ### Issues/PRs references 19286: cpu/esp_common: use generic WIFI_SSID/WIFI_PASS defines r=benpicco a=benpicco Co-authored-by: Karl Fessel <[email protected]> Co-authored-by: Gunar Schorcht <[email protected]> Co-authored-by: Benjamin Valentin <[email protected]>

bors · 2023-02-17T16:39:33Z

Build failed (retrying...):

Murdock

19269: cpu/gd32v/periph_i2c: interrupt based driver r=benpicco a=gschorcht ### Contribution description This PR provides an interrupt-driven version of the I2C low-level driver. The existing I2C low-level driver for GDVF103 uses a busy-waiting approach where the status register is continuously polled while waiting for a certain status when sending or receiving. The MCU is thus occupied the whole time during a send or receive operation. The driver provided with this PR uses an interrupt-driven approach. This is, while waiting for a certain status when sending or receiving, the calling thread is suspended and woken up by interrupts. Since the I2C controller allows to receive up to two bytes before the application has to react, receiving a single byte, two bytes or more than two bytes needs a different handling for correct receiption. This requires a tricky implementation which distinguish a number of different case. There the driver requires 860 byte more ROM and 8 byte more RAM. ### Testing procedure The driver should work with any I2C sensor/actuator. It was tested with - `tests/driver_bmp180` <details> ``` main(): This is RIOT! (Version: 2023.04-devel-355-g940c7-cpu/gd32v/periph_i2c_interrupt_driven) BMP180 test application +------------Initializing------------+ Initialization successful +------------Calibration------------+ AC1: 8448 AC2: -1208 AC3: -14907 AC4: 33310 AC5: 24774 AC6: 19213 B1: 6515 B2: 49 MB: -32768 MC: -11786 MD: 2958 +--------Starting Measurements--------+ Temperature [°C]: 22.0 Pressure [hPa]: 1006.49 Pressure at see level [hPa]: 1025.55 Altitude [m]: 157 +-------------------------------------+ Temperature [°C]: 22.0 Pressure [hPa]: 1006.56 Pressure at see level [hPa]: 1025.58 Altitude [m]: 157 +-------------------------------------+ ``` </details> - `tests/driver_ccs811` <details> ``` main(): This is RIOT! (Version: 2023.04-devel-355-g940c7-cpu/gd32v/periph_i2c_interrupt_driven) CCS811 test application +------------Initializing------------+ +--------Starting Measurements--------+ TVOC [ppb]: 0 eCO2 [ppm]: 0 +-------------------------------------+ TVOC [ppb]: 0 eCO2 [ppm]: 0 +-------------------------------------+ TVOC [ppb]: 0 eCO2 [ppm]: 0 +-------------------------------------+ TVOC [ppb]: 0 eCO2 [ppm]: 400 +-------------------------------------+ TVOC [ppb]: 0 eCO2 [ppm]: 400 +-------------------------------------+ TVOC [ppb]: 0 eCO2 [ppm]: 400 +-------------------------------------+ TVOC [ppb]: 7 eCO2 [ppm]: 446 +-------------------------------------+ TVOC [ppb]: 7 eCO2 [ppm]: 446 +-------------------------------------+ TVOC [ppb]: 7 eCO2 [ppm]: 446 +-------------------------------------+ TVOC [ppb]: 7 eCO2 [ppm]: 446 +-------------------------------------+ ``` </details> - `tests/driver_sht3x` <details> ``` main(): This is RIOT! (Version: 2023.04-devel-355-g940c7-cpu/gd32v/periph_i2c_interrupt_driven) SHT3X test application +------------Initializing------------+ Initialization successful +--------Starting Measurements--------+ Temperature [°C]: 21.46 Relative Humidity [%]: 54.50 +-------------------------------------+ Temperature [°C]: 21.47 Relative Humidity [%]: 54.53 +-------------------------------------+ Temperature [°C]: 21.46 Relative Humidity [%]: 54.48 +-------------------------------------+ Temperature [°C]: 21.46 Relative Humidity [%]: 54.47 +-------------------------------------+ ``` </details> - `tests/driver_l3gxxxx` <details> ``` main(): This is RIOT! (Version: 2023.04-devel-375-g75547-cpu/gd32v/periph_i2c_interrupt_driven) L3GXXXX gyroscope driver test application Initializing L3GXXXX sensor [OK] gyro [dps] x: +0, y: -1, z: -2 gyro [dps] x: +0, y: +0, z: +0 gyro [dps] x: +0, y: +0, z: +0 gyro [dps] x: +0, y: +0, z: +0 gyro [dps] x: +0, y: +0, z: +0 gyro [dps] x: +0, y: +0, z: +0 gyro [dps] x: -1, y: +0, z: +4 gyro [dps] x: +0, y: +0, z: -21 gyro [dps] x: +0, y: +0, z: +6 gyro [dps] x: -43, y: +0, z: -13 gyro [dps] x: -21, y: -2, z: +0 gyro [dps] x: +0, y: +1, z: +3 gyro [dps] x: +25, y: +0, z: +0 ``` </details> - `tests/driver_hd44780` with `pcf8574a` I2C interface ### Issues/PRs references 19286: cpu/esp_common: use generic WIFI_SSID/WIFI_PASS defines r=benpicco a=benpicco Co-authored-by: Gunar Schorcht <[email protected]> Co-authored-by: Benjamin Valentin <[email protected]>

benpicco · 2023-02-17T16:44:19Z

bors cancel
bors merge

bors · 2023-02-17T16:44:20Z

Canceled.

benpicco · 2023-02-17T16:46:19Z

bors merge

bors · 2023-02-17T16:46:21Z

Already running a review

19027: sys/fmt: optimize scn_u32_dec scn_u32_hex r=benpicco a=kfessel ### Contribution description Improves the compilation result for `scn_u32_dec` `scn_u32_hex` especially on `cortex-m` reducing either stack usage and or code size. This makes use of unsigned int overflow (slightly less better without doing that `hexn`). See godbolt (original versions got an `o` attached, modified versions got `k`s) all functions are marked `_S_` defined to `static` by assigning the global at end the compiled function can be changed (`deco deck hexo hexk hexkk hexn`) this PR is `hexkk` and `deck` ### Testing procedure run unit-test/test-fmt ``` <RIOT>/tests/unittests$ make tests-fmt <RIOT>/tests/unittests$ make term ``` ### Issues/PRs references [godbolt](https://godbolt.org/z/MzT1zh4q1) 19269: cpu/gd32v/periph_i2c: interrupt based driver r=benpicco a=gschorcht ### Contribution description This PR provides an interrupt-driven version of the I2C low-level driver. The existing I2C low-level driver for GDVF103 uses a busy-waiting approach where the status register is continuously polled while waiting for a certain status when sending or receiving. The MCU is thus occupied the whole time during a send or receive operation. The driver provided with this PR uses an interrupt-driven approach. This is, while waiting for a certain status when sending or receiving, the calling thread is suspended and woken up by interrupts. Since the I2C controller allows to receive up to two bytes before the application has to react, receiving a single byte, two bytes or more than two bytes needs a different handling for correct receiption. This requires a tricky implementation which distinguish a number of different case. There the driver requires 860 byte more ROM and 8 byte more RAM. ### Testing procedure The driver should work with any I2C sensor/actuator. It was tested with - `tests/driver_bmp180` <details> ``` main(): This is RIOT! (Version: 2023.04-devel-355-g940c7-cpu/gd32v/periph_i2c_interrupt_driven) BMP180 test application +------------Initializing------------+ Initialization successful +------------Calibration------------+ AC1: 8448 AC2: -1208 AC3: -14907 AC4: 33310 AC5: 24774 AC6: 19213 B1: 6515 B2: 49 MB: -32768 MC: -11786 MD: 2958 +--------Starting Measurements--------+ Temperature [°C]: 22.0 Pressure [hPa]: 1006.49 Pressure at see level [hPa]: 1025.55 Altitude [m]: 157 +-------------------------------------+ Temperature [°C]: 22.0 Pressure [hPa]: 1006.56 Pressure at see level [hPa]: 1025.58 Altitude [m]: 157 +-------------------------------------+ ``` </details> - `tests/driver_ccs811` <details> ``` main(): This is RIOT! (Version: 2023.04-devel-355-g940c7-cpu/gd32v/periph_i2c_interrupt_driven) CCS811 test application +------------Initializing------------+ +--------Starting Measurements--------+ TVOC [ppb]: 0 eCO2 [ppm]: 0 +-------------------------------------+ TVOC [ppb]: 0 eCO2 [ppm]: 0 +-------------------------------------+ TVOC [ppb]: 0 eCO2 [ppm]: 0 +-------------------------------------+ TVOC [ppb]: 0 eCO2 [ppm]: 400 +-------------------------------------+ TVOC [ppb]: 0 eCO2 [ppm]: 400 +-------------------------------------+ TVOC [ppb]: 0 eCO2 [ppm]: 400 +-------------------------------------+ TVOC [ppb]: 7 eCO2 [ppm]: 446 +-------------------------------------+ TVOC [ppb]: 7 eCO2 [ppm]: 446 +-------------------------------------+ TVOC [ppb]: 7 eCO2 [ppm]: 446 +-------------------------------------+ TVOC [ppb]: 7 eCO2 [ppm]: 446 +-------------------------------------+ ``` </details> - `tests/driver_sht3x` <details> ``` main(): This is RIOT! (Version: 2023.04-devel-355-g940c7-cpu/gd32v/periph_i2c_interrupt_driven) SHT3X test application +------------Initializing------------+ Initialization successful +--------Starting Measurements--------+ Temperature [°C]: 21.46 Relative Humidity [%]: 54.50 +-------------------------------------+ Temperature [°C]: 21.47 Relative Humidity [%]: 54.53 +-------------------------------------+ Temperature [°C]: 21.46 Relative Humidity [%]: 54.48 +-------------------------------------+ Temperature [°C]: 21.46 Relative Humidity [%]: 54.47 +-------------------------------------+ ``` </details> - `tests/driver_l3gxxxx` <details> ``` main(): This is RIOT! (Version: 2023.04-devel-375-g75547-cpu/gd32v/periph_i2c_interrupt_driven) L3GXXXX gyroscope driver test application Initializing L3GXXXX sensor [OK] gyro [dps] x: +0, y: -1, z: -2 gyro [dps] x: +0, y: +0, z: +0 gyro [dps] x: +0, y: +0, z: +0 gyro [dps] x: +0, y: +0, z: +0 gyro [dps] x: +0, y: +0, z: +0 gyro [dps] x: +0, y: +0, z: +0 gyro [dps] x: -1, y: +0, z: +4 gyro [dps] x: +0, y: +0, z: -21 gyro [dps] x: +0, y: +0, z: +6 gyro [dps] x: -43, y: +0, z: -13 gyro [dps] x: -21, y: -2, z: +0 gyro [dps] x: +0, y: +1, z: +3 gyro [dps] x: +25, y: +0, z: +0 ``` </details> - `tests/driver_hd44780` with `pcf8574a` I2C interface ### Issues/PRs references 19284: boards: support for the LILYGO TTGO T8 ESP32-S2 board r=benpicco a=gschorcht ### Contribution description This PR provides the support for the LILYGO TTGO T8 ESP32-S2 board which has a OLED display (not yet supported) and a SD-Card slot on board. The board is equipped with a USB-C connector that connects either to a USB-to-UART bridge or to the USB-OTG/JTAG interface of the ESP32-S2 via some DIP switches. The PR includes a very small fix of printf format string in `tests/malloc`. I can split it off. ### Testing procedure t.b.d. ### Issues/PRs references 19286: cpu/esp_common: use generic WIFI_SSID/WIFI_PASS defines r=benpicco a=benpicco Co-authored-by: Karl Fessel <[email protected]> Co-authored-by: Gunar Schorcht <[email protected]> Co-authored-by: Benjamin Valentin <[email protected]>

bors · 2023-02-17T16:58:54Z

Build failed (retrying...):

Murdock

bors · 2023-02-17T20:01:29Z

Build succeeded:

benpicco requested review from smlng, leandrolanzieri, aabadie, MichelRottleuthner, fjmolinas and gschorcht as code owners February 17, 2023 14:21

github-actions bot added Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: examples Area: Example Applications Area: tests Area: tests and testing framework Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Feb 17, 2023

benpicco force-pushed the esp_wifi_pass branch 2 times, most recently from d95e3d2 to 74b22f8 Compare February 17, 2023 14:27

benpicco added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 17, 2023

cpu/esp_common: use generic WIFI_SSID/WIFI_PASS defines

50802b8

benpicco force-pushed the esp_wifi_pass branch from 74b22f8 to 50802b8 Compare February 17, 2023 14:32

maribu approved these changes Feb 17, 2023

View reviewed changes

gschorcht requested changes Feb 17, 2023

View reviewed changes

cpu/esp32/doc.txt Outdated Show resolved Hide resolved

cpu/esp32/doc.txt Outdated Show resolved Hide resolved

cpu/esp_common/esp-wifi/doc.txt Outdated Show resolved Hide resolved

cpu/esp_common/esp-wifi/doc.txt Outdated Show resolved Hide resolved

bors bot added a commit that referenced this pull request Feb 17, 2023

Merge #19286

693b9c9

19286: cpu/esp_common: use generic WIFI_SSID/WIFI_PASS defines r=maribu a=benpicco Co-authored-by: Benjamin Valentin <[email protected]>

benpicco commented Feb 17, 2023

View reviewed changes

gschorcht reviewed Feb 17, 2023

View reviewed changes

cpu/esp_common/esp-wifi/esp_wifi_netdev.c Show resolved Hide resolved

gschorcht reviewed Feb 17, 2023

View reviewed changes

cpu/esp_common/esp-wifi/esp_wifi_netdev.c Outdated Show resolved Hide resolved

cpu/esp_common: rename ESP_WIFI_EAP_* -> WIFI_EAP_*

cebd768

benpicco force-pushed the esp_wifi_pass branch from d9043d9 to cebd768 Compare February 17, 2023 15:59

gschorcht approved these changes Feb 17, 2023

View reviewed changes

bors bot merged commit b1be519 into RIOT-OS:master Feb 17, 2023

benpicco deleted the esp_wifi_pass branch February 17, 2023 23:01

MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cpu/esp_common: use generic WIFI_SSID/WIFI_PASS defines #19286

cpu/esp_common: use generic WIFI_SSID/WIFI_PASS defines #19286

benpicco commented Feb 17, 2023

riot-ci commented Feb 17, 2023 •

edited

Loading

maribu commented Feb 17, 2023

gschorcht commented Feb 17, 2023

maribu commented Feb 17, 2023

bors bot commented Feb 17, 2023

benpicco commented Feb 17, 2023

gschorcht commented Feb 17, 2023

benpicco Feb 17, 2023

benpicco Feb 17, 2023

gschorcht Feb 17, 2023

gschorcht commented Feb 17, 2023

gschorcht commented Feb 17, 2023

bors bot commented Feb 17, 2023

benpicco commented Feb 17, 2023

bors bot commented Feb 17, 2023

benpicco commented Feb 17, 2023

bors bot commented Feb 17, 2023

benpicco commented Feb 17, 2023

bors bot commented Feb 17, 2023

bors bot commented Feb 17, 2023

bors bot commented Feb 17, 2023

cpu/esp_common: use generic WIFI_SSID/WIFI_PASS defines #19286

cpu/esp_common: use generic WIFI_SSID/WIFI_PASS defines #19286

Conversation

benpicco commented Feb 17, 2023

Contribution description

Testing procedure

Issues/PRs references

riot-ci commented Feb 17, 2023 • edited Loading

Murdock results

Artifacts

maribu commented Feb 17, 2023

gschorcht commented Feb 17, 2023

maribu commented Feb 17, 2023

bors bot commented Feb 17, 2023

benpicco commented Feb 17, 2023

gschorcht commented Feb 17, 2023

benpicco Feb 17, 2023

Choose a reason for hiding this comment

benpicco Feb 17, 2023

Choose a reason for hiding this comment

gschorcht Feb 17, 2023

Choose a reason for hiding this comment

gschorcht commented Feb 17, 2023

gschorcht commented Feb 17, 2023

bors bot commented Feb 17, 2023

benpicco commented Feb 17, 2023

bors bot commented Feb 17, 2023

benpicco commented Feb 17, 2023

bors bot commented Feb 17, 2023

benpicco commented Feb 17, 2023

bors bot commented Feb 17, 2023

bors bot commented Feb 17, 2023

bors bot commented Feb 17, 2023

riot-ci commented Feb 17, 2023 •

edited

Loading