nanocoap_sock: store message ID in nanocoap_sock_t #19178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
requested review from
miri64,
haukepetersen,
PeterKietzmann and
cgundogan
as code owners
github-actions
bot
added
Area: CoAP
benpicco
added
the
CI: ready for build
maribu
approved these changes
Jan 20, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 23, 2023
19178: nanocoap_sock: store message ID in nanocoap_sock_t r=benpicco a=benpicco Co-authored-by: Benjamin Valentin <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Create a new message ID for each nanoCoAP socket.
This addresses the concerns raised when I attempted to create a common
coap_next_msg_id().With the requirements brought up in the discussion, such a common function is not possible across GCoAP and nanoCoAP, so at least have such a function for all nanoCoAP users.
Testing procedure
Issues/PRs references
alternative to #18991