Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: update check-labels-action #19101

Merged
merged 2 commits into from
Jan 16, 2023
Merged

CI: update check-labels-action #19101

merged 2 commits into from
Jan 16, 2023

Conversation

kaspar030
Copy link
Contributor

@kaspar030 kaspar030 commented Jan 6, 2023 •
edited
Loading

Contribution description

This PR bumps the check-labels-action to the new version that sets a "Process: missing approvals" label, to be used as bors "block_labels" instead of relying on bors to pick up changes to the check-labels status.

TESTING STILL waiting for RIOT-OS/check-labels-action#1 to be merged & tagged

Testing procedure

Issues/PRs references

@github-actions github-actions bot added the Area: CI Area: Continuous Integration of RIOT components label Jan 6, 2023
@kaspar030 kaspar030 added the Process: needs >1 ACK Integration Process: This PR requires more than one ACK label Jan 6, 2023
@benpicco
Copy link
Contributor

benpicco commented Jan 9, 2023

Is that label set / removed automatically?

@kaspar030
Copy link
Contributor Author

Is that label set / removed automatically?

That's the idea, I'm trying to add that to the label checker.

@miri64
Copy link
Member

miri64 commented Jan 10, 2023

As discussed offline: Let's merge this and test in master. GITHUB_TOKEN has restricted permissions for PRs (which was already a problem in the past). @kaspar030 please squash.

@miri64 miri64 added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 10, 2023
@riot-ci
Copy link

riot-ci commented Jan 10, 2023 •
edited
Loading

Murdock results

✔️ PASSED

1dabd68 CI: temporarily remove check-labels from bors pr_status

Success Failures Total Runtime
1 0 1 55s

Artifacts

@kaspar030 kaspar030 changed the title CI: updating check-labels-action CI: update check-labels-action Jan 10, 2023
@kaspar030 kaspar030 mentioned this pull request Jan 10, 2023
Merged
@miri64
Copy link
Member

miri64 commented Jan 16, 2023

RIOT-OS/check-labels-action#1 is merged. Please rebase and mark ready for review, so we can tentatively merge this (otherwise AFAIK there is no real way to test this)

@miri64 miri64 removed the Process: needs >1 ACK Integration Process: This PR requires more than one ACK label Jan 16, 2023
@kaspar030 kaspar030 marked this pull request as ready for review January 16, 2023 11:47
@kaspar030
Copy link
Contributor Author

If we merge this and sth goes wrong, the action might never succeed and we need to force merging any fix.
Should we maybe disable bors' check for the action until we know it works?

@miri64
Copy link
Member

miri64 commented Jan 16, 2023

Should we maybe disable bors' check for the action until we know it works?

Which check exactly?

@kaspar030
Copy link
Contributor Author

Which check exactly?

I mean this one:

RIOT/bors.toml

Line 6 in 6fb340d

"check-labels",

@miri64
Copy link
Member

miri64 commented Jan 16, 2023

👍 I was not sure if you meant disable bors altogether, but temporarily disabling the label check is fine for me. Can you piggyback this?

miri64
miri64 reviewed Jan 16, 2023
View reviewed changes
bors.toml Show resolved Hide resolved
@miri64 miri64 added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Jan 16, 2023
@miri64
Copy link
Member

miri64 commented Jan 16, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 16, 2023

👎 Rejected by too few approved reviews

miri64
miri64 approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@miri64
Copy link
Member

miri64 commented Jan 16, 2023

bors merge ...

@miri64
Copy link
Member

miri64 commented Jan 16, 2023

bors cancel
bors merge

@bors
Copy link
Contributor

bors bot commented Jan 16, 2023

Canceled.

@bors
Copy link
Contributor

bors bot commented Jan 16, 2023

Build succeeded:

@bors bors bot merged commit 211db05 into RIOT-OS:master Jan 16, 2023
@kaspar030 kaspar030 deleted the update_check_labels branch January 16, 2023 18:49
@kaspar030 kaspar030 mentioned this pull request Jan 17, 2023
Merged
@miri64 miri64 mentioned this pull request Jan 17, 2023
Merged
@jia200x jia200x added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
5 participants
@kaspar030 @benpicco @miri64 @riot-ci @jia200x