Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/atmega_common/periph_timer: fix spurious IRQs [backport 2022.10] #18981

Merged
merged 1 commit into from
Nov 27, 2022
Merged

cpu/atmega_common/periph_timer: fix spurious IRQs [backport 2022.10] #18981

merged 1 commit into from
Nov 27, 2022

Conversation

maribu
Copy link
Member

@maribu maribu commented Nov 26, 2022

Backport of #18978

Contribution description

As the tile says

Testing procedure

tests/periph_timer from #18963 and tests/periph_timer_periodic should pass. (They do on the arduino-mega2560.)

Issues/PRs references

#18976

@maribu maribu requested a review from kYc0o as a code owner November 26, 2022 20:19
@maribu maribu added Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: AVR Platform: This PR/issue effects AVR-based platforms Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Nov 26, 2022
@maribu maribu mentioned this pull request Nov 26, 2022
Merged
@riot-ci
Copy link

riot-ci commented Nov 26, 2022

Murdock results

✔️ PASSED

ce60961 cpu/atmega_common/periph_timer: fix spurious IRQs

Success Failures Total Runtime
115836 0 115836 01h:59m:19s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

aabadie
aabadie approved these changes Nov 27, 2022
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aabadie aabadie merged commit c3e83d0 into RIOT-OS:2022.10-branch Nov 27, 2022
@maribu maribu deleted the backport/2022.10/cpu/atmega_common/periph_timer/spurious_irqs branch November 27, 2022 07:55
@maribu
Copy link
Member Author

maribu commented Nov 27, 2022

Thx :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@kYc0o kYc0o Awaiting requested review from kYc0o kYc0o is a code owner

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: AVR Platform: This PR/issue effects AVR-based platforms Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maribu @riot-ci @aabadie