Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/atmega_common/periph_timer: fix spurious IRQs #18978

Merged
merged 1 commit into from
Nov 26, 2022
Merged

cpu/atmega_common/periph_timer: fix spurious IRQs #18978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions cpu/atmega_common/periph/timer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,9 @@ int timer_set_absolute(tim_t tim, int channel, unsigned int value)
unsigned state = irq_disable();

ctx[tim].dev->OCR[channel] = (uint16_t)value;
*ctx[tim].flag &= ~(1 << (channel + OCF1A));
/* clear spurious IRQs, if any */
*ctx[tim].flag = (1 << (channel + OCF1A));
/* unmask IRQ */
*ctx[tim].mask |= (1 << (channel + OCIE1A));
set_oneshot(tim, channel);

Expand All @@ -177,6 +179,9 @@ int timer_set(tim_t tim, int channel, unsigned int timeout)
unsigned absolute = ctx[tim].dev->CNT + timeout;

ctx[tim].dev->OCR[channel] = absolute;
/* clear spurious IRQs, if any */
*ctx[tim].flag = (1 << (channel + OCF1A));
/* unmask IRQ */
*ctx[tim].mask |= (1 << (channel + OCIE1A));
set_oneshot(tim, channel);

Expand Down Expand Up @@ -210,7 +215,9 @@ int timer_set_periodic(tim_t tim, int channel, unsigned int value, uint8_t flags

ctx[tim].dev->OCR[channel] = (uint16_t)value;

*ctx[tim].flag &= ~(1 << (channel + OCF1A));
/* clear spurious IRQs, if any */
*ctx[tim].flag = (1 << (channel + OCF1A));
/* unmask IRQ */
*ctx[tim].mask |= (1 << (channel + OCIE1A));

clear_oneshot(tim, channel);
Expand Down