Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/pkg_utensor: increase main threads stack size #18952

Merged
merged 1 commit into from
Nov 23, 2022
Merged

tests/pkg_utensor: increase main threads stack size #18952

merged 1 commit into from
Nov 23, 2022

Conversation

maribu
Copy link
Member

@maribu maribu commented Nov 22, 2022

Contribution description

The MPU based stack guard is very unpleased by the stack overflow happening during the test. The increase in stack size makes the MPU stack guard happy again.

Testing procedure

make BOARD=nrf52840dk -C tests/pkg_utensor flash test

In master, the test fails with a stack overflow being detected. In this PR, it succeeds.

Issues/PRs references

None

@maribu
tests/pkg_utensor: increase main threads stack size
22f882d 
The MPU based stack guard is very unpleased by the stack overflow
happening during the test. The increase in stack size makes the MPU
stack guard happy again.
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Nov 22, 2022
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 23, 2022
@riot-ci
Copy link

riot-ci commented Nov 23, 2022

Murdock results

✔️ PASSED

22f882d tests/pkg_utensor: increase main threads stack size

Success Failures Total Runtime
222 0 223 01m:54s

Artifacts

aabadie
aabadie approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust your testing.

ACK

@aabadie aabadie merged commit a87a066 into RIOT-OS:master Nov 23, 2022
@maribu maribu deleted the tests/pkg_utensor branch November 23, 2022 14:10
@maribu
Copy link
Member Author

maribu commented Nov 23, 2022

Thx :)

@benpicco benpicco mentioned this pull request Nov 23, 2022
Merged
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2023.01
Development

Successfully merging this pull request may close these issues.
4 participants
@maribu @riot-ci @aabadie @kaspar030