sys/tiny_strerror: add tiny_strerror_minimal #18768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: build system
maribu
approved these changes
Oct 18, 2022
| @@ -117,6 +118,12 @@ const char *tiny_strerror(int errnum) | |||
| errnum = -errnum; | |||
| } | |||
|
|
|||
| if (IS_USED(MODULE_TINY_STRERROR_MINIMAL)) { | |||
| static char buf[4]; | |||
There was a problem hiding this comment.
This is not thread-safe. I don't think this is much of an issue, as in few cases more than one thread cares about user-friendly error messages. And if so they would have to interrupt each other during error reporting. And even then likely they report errors via stdio, which gets garbled anyway when two threads concurrently write to it.
Still, I think this is something we need to point out clearly with a big fat @warning.
benpicco
force-pushed
the
tiny_strerror_minimal
branch
from
d67e5f1
to
6295a67
Compare
benpicco
force-pushed
the
tiny_strerror_minimal
branch
from
6295a67
to
8553c8f
Compare
benpicco
added
the
CI: ready for build
Murdock results✔️ PASSED 8553c8f sys/tiny_strerror: add tiny_strerror_minimal
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
tiny_strerroris still quite heavy (1200 bytes on Cortex-M4), so add a more minimal version that only prints the error code.This allows to use the same code and have pretty error messages if ROM is ample, but still have the option to strip it down easily.
Testing procedure
Issues/PRs references