Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/stm32: fix periph_dma #18711

Merged
merged 3 commits into from
Oct 27, 2022
Merged

cpu/stm32: fix periph_dma #18711

merged 3 commits into from
Oct 27, 2022

Commits on Oct 26, 2022

  1. cpu/stm32/periph/dma: fix DMA2 on STMF3 families 

    As it was, the calculation of DMA2's IRQ number was inccrorect for some
STM families. The implmentation alocates streams numbers 0 to 7 for the
first DMA controller and 8 and up for the second DMA controller. This
offset of +8 was not accounted for when IRQ's of the second DMA
controller was calculated. This patch corrects this.
    @Enoch247
    Enoch247 committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    264a7c8 View commit details
    Browse the repository at this point in the history

  2. cpu/stm32/periph/dma: fix dma_resume 

    As implmented, dma_resume assumed that transfers widths were 1 byte and
that the memory address incrmenting was always on and periphial address
incrementing always off. This resulted in memory corruption anytime
these assumptions were not true and a dma was resumed. The DMA module
allows intitiating transfers that did not meet these assumption.

This patch adds proper handling inside dma_resume to safely resume any
transfer. Clearifications and errors are added/fixed in the module's
header file. Also, a few constants are removed from the gobal namespace.
    @Enoch247
    Enoch247 committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    c888c10 View commit details
    Browse the repository at this point in the history

  3. cpu/stm32/periph/dma: make dma_prepare() generic 

    This patch makes dma_prepare() handle register names a bit more
generically.
    @Enoch247
    Enoch247 committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    4e2c63c View commit details
    Browse the repository at this point in the history