sys/net/network_layer/ipv4/addr: add ipv4_addr_print function #18694
Conversation
HendrikVE
requested review from
miri64,
haukepetersen,
PeterKietzmann and
cgundogan
as code owners
HendrikVE
added
CI: ready for build
aabadie
added
CI: ready for build
Murdock results✔️ PASSED 6c98a5b sys/net/network_layer/ipv4/addr: add ipv4_addr_print function
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
HendrikVE
force-pushed
the
pr/add_ipv4_addr_print
branch
from
ac96a07
to
6c98a5b
Compare
aabadie
added
CI: ready for build
| { | ||
| assert(addr); | ||
| char addr_str[IPV4_ADDR_MAX_STR_LEN]; | ||
| ipv4_addr_to_str(addr_str, addr, sizeof(addr_str)); |
There was a problem hiding this comment.
Where is this function implemented? Wouldn't it make sense to add ipv4_addr_print() there as well?
There was a problem hiding this comment.
ipv4_addr_to_str can be found in net/ipv4/addr.h like ipv6_addr_to_str can be found in net/ipv6/addr.h. I'm just placing the IPv4 variants relative to their respective IPv6 counterparts ;)
There was a problem hiding this comment.
In net/ipv6/addr.h there is just the definition of ipv4_addr_to_str(), but I now saw, that they are in their own compile unit ipv6_addr_to_str.c. So nvm.
Contribution description
Adds the function
ipv4_addr_print, similar to the already existing toipv6_addr_print.Issues/PRs references
Dependency for and split out from #16853