-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys/shell/vfs: make output of vfs df human readable #18550
Conversation
1cf3891
to
3f349ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Since you are touching the code anyway: Care to replace "Capacity" in the table header by something more sensible? E.g. when capacity is at 100%, I would assume an empty file storage. I think df
is showing Use%
there, if I recall correctly
Looks like this now
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx :)
08ab8a0
to
2d45fca
Compare
Contribution description
Currently
vfs df
outputs size as filesystem blocks. It is not clear how big a filesystem block is, so the output is hard to interpret.Instead, output the sizes in Bytes like
df -h
.Testing procedure
Run e.g.
examples/filesystem
:Issues/PRs references