-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove version comment fixing build issue #18489
Conversation
To test, I think you have to have an old checkout of the pkg; trying... |
Testing is highly nontrivial because it only triggers if the relevant hash is not present in the existing checkout -- merely cleaning, going to 2022.04, running the test, going to master and running the test again does not trigger the failure, because if you do that now, then you get a recent checkout and the requested hash is already present. So, steps to test are (not necessarily minimized):
Then you get:
To quote @nica-f: "Ein schöner corner corner corner case". The presented patch fixes this. I suggest that we remove all these comments tree-wide, as that's a very subtle thing to run into. |
... or move them to another line, they do provide information. The reasons why we use hashes in the first place are, 1.) git-cache is flakey with tags, and 2.) only hashes ensure immutability. |
Makefiles don't do comments, so these were forwarded into the variable. *Most* users would expand the arguments to a shell where it'd be ignored, but not all of them. Contributes-To: RIOT-OS#18489 (This is also where the one version that is added here was removed).
Makefiles don't do comments, so these were forwarded into the variable. *Most* users would expand the arguments to a shell where it'd be ignored, but not all of them. Contributes-To: RIOT-OS#18489 (This is also where the one version that is added here was removed).
Contribution description
This change resolves a built issue cause by the added comment to the release tag in the Makefile.
Testing procedure
Tested by compiling a project using LVGL.
Issues/PRs references
N/A