Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/lvgl: bump to v8.3.0 #18301

Merged
merged 1 commit into from
Jul 15, 2022
Merged

pkg/lvgl: bump to v8.3.0 #18301

merged 1 commit into from
Jul 15, 2022

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jul 6, 2022

Contribution description

As the title says.

The patch added in #17681 is removed since this release contains the same change.
The test applications work on adafruit-clue and native (using lv_drivers). I don't have a board for testing the touch variant but this also works on native.

I noticed a code size increase of 3KB.

Testing procedure

  • Green Murdock
  • Some on-board testing is partially done

Issues/PRs references

None

@github-actions github-actions bot added the Area: pkg Area: External package ports label Jul 6, 2022
@aabadie aabadie mentioned this pull request Jul 6, 2022
Merged
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 6, 2022
@aabadie
Copy link
Contributor Author

aabadie commented Jul 7, 2022

Just tested this PR with success on stm32f429i-disc1.

@aabadie
Copy link
Contributor Author

aabadie commented Jul 8, 2022

This one has unrelated build failures even though it's rebased on latest master. Are there any problems with CI workers (last one was on riotbuild) ?

@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 8, 2022
@aabadie
Copy link
Contributor Author

aabadie commented Jul 8, 2022

Are there any problems with CI workers (last one was on riotbuild) ?

Failures are not bound to a worker so it seems to be more general. I'll retrigger without build since the failures are all unrelated.

@aabadie aabadie added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 8, 2022
@chrysn chrysn added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 10, 2022
@chrysn
Copy link
Member

chrysn commented Jul 10, 2022

Looks good to me, but we'll need to find how this breaks builds. Started another CI run for inspection.

@aabadie
Copy link
Contributor Author

aabadie commented Jul 11, 2022

we'll need to find how this breaks builds. Started another CI run for inspection

This is still failing and reported failures are unrelated. This looks random: it's not always the same failures and they happen on different workers.

@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 12, 2022
@aabadie
Copy link
Contributor Author

aabadie commented Jul 13, 2022

This is finally green :)

@benpicco benpicco merged commit b93117b into RIOT-OS:master Jul 15, 2022
@aabadie aabadie deleted the pr/pkg/lvgl-8.3.0 branch July 15, 2022 14:56
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @chrysn @benpicco