Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/esp32: use ESP-IDF spi HAL for periph/spi #18281

Merged
merged 2 commits into from
Jul 15, 2022
Merged

cpu/esp32: use ESP-IDF spi HAL for periph/spi #18281

merged 2 commits into from
Jul 15, 2022

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR is a split-off from PR #17841 and provides the following changes:

  • Uses the former periph/spi implementation only for ESP8266. It is therefore moved from cpu/esp_common/periph to cpu/esp8266/perip.
  • Implements periph/spi for ESP32x SoC using using the ESP-IDF spi HAL interface.

Testing procedure

Compile and test

USEMODULE='esp_log_startup' BOARD=esp32-wroom-32 make -j8 -C tests/periph_spi flash term

Issues/PRs references

Split-off from PR #17841

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jun 28, 2022
@gschorcht gschorcht added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 28, 2022
@gschorcht gschorcht requested a review from benpicco June 28, 2022 19:24
benpicco
benpicco reviewed Jul 13, 2022
View reviewed changes
cpu/esp32/periph/spi.c Outdated Show resolved Hide resolved
benpicco
benpicco reviewed Jul 13, 2022
View reviewed changes
cpu/esp32/periph/spi.c Outdated Show resolved Hide resolved
benpicco
benpicco reviewed Jul 13, 2022
View reviewed changes
cpu/esp32/periph/spi.c Outdated Show resolved Hide resolved
benpicco
benpicco approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash!

@gschorcht gschorcht force-pushed the cpu/esp32/periph_hal_esp32_spi branch 2 times, most recently from bcce540 to fdbe37a Compare July 15, 2022 06:56
@gschorcht
cpu/esp_common: move periph/spi to cpu/esp8266
8f3df0e 
periph/spi implementation can be used for ESP8266 only from now. An implementation using the ESP-IDF spi HAL interface is required for ESP32x SoCs.
@gschorcht
cpu/esp32: port periph/spi to ESP-IDF spi LL API
9142edc
@gschorcht gschorcht force-pushed the cpu/esp32/periph_hal_esp32_spi branch from fdbe37a to 9142edc Compare July 15, 2022 06:57
@benpicco benpicco enabled auto-merge July 15, 2022 08:57
@benpicco benpicco merged commit 295f4a5 into RIOT-OS:master Jul 15, 2022
@gschorcht gschorcht deleted the cpu/esp32/periph_hal_esp32_spi branch July 15, 2022 12:14
@gschorcht gschorcht mentioned this pull request Jul 18, 2022
Closed
@gschorcht gschorcht mentioned this pull request Jul 31, 2022
Merged
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@gschorcht @benpicco @chrysn