sys/shell: drop _builtin_cmds define

[kaspar030]

Contribution description

Arch just upgraded to arm-none-eabi-gcc 12.1.0, and a new warning popped up:

/home/kaspar/src/riot.rs/sys/shell/shell.c: In function 'find_handler':                                                                            
/home/kaspar/src/riot.rs/sys/shell/shell.c:120:42: error: the comparison will always evaluate as 'true' for the address of '_shell_command_list' wi
ll never be NULL [-Werror=address]                                                                                                                 
  120 |     if (handler == NULL && _builtin_cmds != NULL) {                                                                                        
      |                                          ^~                                                                                                
In file included from /home/kaspar/src/riot.rs/sys/shell/shell.c:41:                                                                               
/home/kaspar/src/riot.rs/sys/include/shell_commands.h:44:30: note: '_shell_command_list' declared here                                             
   44 | extern const shell_command_t _shell_command_list[];                                                                                        
      |                              ^~~~~~~~~~~~~~~~~~~                                                                                           
/home/kaspar/src/riot.rs/sys/shell/shell.c: In function 'print_help':                                                                              
/home/kaspar/src/riot.rs/sys/shell/shell.c:155:23: error: the comparison will always evaluate as 'true' for the address of '_shell_command_list' wi
ll never be NULL [-Werror=address]                                                                                                                 
  155 |     if (_builtin_cmds != NULL) {                                                                                                           
      |                       ^~                                                                                                                   
/home/kaspar/src/riot.rs/sys/include/shell_commands.h:44:30: note: '_shell_command_list' declared here                                             
   44 | extern const shell_command_t _shell_command_list[];                                                                                        
      |                              ^~~~~~~~~~~~~~~~~~~                                                                                           
cc1: all warnings being treated as errors                                                                                                          

The cause was _builtin_cmds being just a define for _shell_command_list[], or, NULL.

That was dependend only on MODULE_SHELL_COMMANDS, so, just use that.

Testing procedure

Issues/PRs references