pkg/uwb-dw1000: fix default group delay, use OTP values when possible #18000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixed the default values for the transmitter calibration block group delay. It seems that when I ported this I set the default group delay to the wrong value of
5
or (DW1000_CHANNEL_DEFAULT
), when the actual correct value for the default channel 5 is0xC0
. This fixes it.Furthermore, by playing with the default firmware decawave provides its boards with there is also calibrated TX_POWER and PG_DELAY values stored in the OTP memory (at least for channel 5). These values are calibrated to account for fabrication process variation in antenna gains among others and therefore be sure that the output TX power is according to regulations, so use them when they are available.
A couple of cleanups are piggy-packed int his PR, mainly to reduce CI builds.
Testing procedure
Bench results of
twr_aloha
against master, a notable improvement should be visible, running on IoT-LAB and evaluating the mean error over 14nodes I get:Issues/PRs references
Split from #17988