Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/uwb-core: adjust holdoff time when rxdiag_enabled #17999

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

fjmolinas
Copy link
Contributor

Contribution description

Currently if enabling uwb-core_rng_trx_info module (which enables RX_DIAGNOSTICS in the uwb-dw1000 package), then TWR exchange procedure fails since it adds some processing delay that is not accounter for in the holdoff time (time before a responder node answers to an initiator TWR request). This PR fixes it by accounting for that in the holdoff configuration values.

Testing procedure

The following fails in master: USEMODULE=uwb-core_rng_trx_info make -C examples/twr_aloha/ flash term -j7

> twr lst on
2022-04-25 13:13:11,759 # twr lst on
2022-04-25 13:13:11,761 # [twr]: start listening
2022-04-25 13:13:32,217 # twr req 03:B4 -p ds -c 5 -i 200
2022-04-25 13:13:32,218 # [twr]: start ranging
2022-04-25 13:13:32,432 # {"t": 32186, "src": "03:B4", "dst": "57:81", "d_cm": 56, "tof": 119.8907700, "los": 0, "rssi": 0}
2022-04-25 13:13:32,632 # {"t": 32386, "src": "03:B4", "dst": "57:81", "d_cm": 57, "tof": 121.8883286, "los": 0, "rssi": 0}
2022-04-25 13:13:32,832 # {"t": 32586, "src": "03:B4", "dst": "57:81", "d_cm": 62, "tof": 134.1226348, "los": 0, "rssi": 0}
2022-04-25 13:13:33,032 # {"t": 32786, "src": "03:B4", "dst": "57:81", "d_cm": 54, "tof": 116.6292953, "los": 0, "rssi": 0}
2022-04-25 13:13:33,232 # {"t": 32986, "src": "03:B4", "dst": "57:81", "d_cm": 58, "tof": 124.8940277, "los": 0, "rssi": 0}

Issues/PRs references

Split from #17988.

Reading the diagnostic information adds a ~160us overhead, so holdoff
for that additional time.
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 25, 2022
@fjmolinas fjmolinas requested a review from aabadie April 25, 2022 11:21
@github-actions github-actions bot added Area: examples Area: Example Applications Area: pkg Area: External package ports labels Apr 25, 2022
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. trusting your testing.

@fjmolinas fjmolinas merged commit 7a85e49 into RIOT-OS:master Apr 26, 2022
@fjmolinas
Copy link
Contributor Author

Thanks!

@fjmolinas fjmolinas deleted the pr_uwb_core_holdoff branch April 26, 2022 06:19
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: examples Area: Example Applications Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants