net/ble/skald: make advertising interval configurable per context #17834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haukepetersen
added
Type: enhancement
haukepetersen
requested review from
leandrolanzieri,
jia200x,
cgundogan,
miri64 and
PeterKietzmann
as code owners
github-actions
bot
added
Area: examples
haukepetersen
changed the title
haukepetersen
force-pushed
the
opt_skald_advitvlconfig
branch
from
b442a24
to
ef925b5
Compare
|
rebased |
miri64
reviewed
May 24, 2022
Comment on lines
-65
to
-67
| #ifndef CONFIG_SKALD_INTERVAL_MS | ||
| #define CONFIG_SKALD_INTERVAL_MS (1000U) | ||
| #endif |
There was a problem hiding this comment.
Does it make sense to keep this? Maybe not as a CONFIG_ define, but at least as a default? This way you would not need to duplicate the defines it in the main.cs
There was a problem hiding this comment.
No, not really. That 1000ms is a pretty arbitrary value and far from a BLE advertising default... So I don't see a benefit of keeping it.
|
Otherwise tested: I can see both beacons with the nRF connect app. |
|
@miri64 are you satisfied by my comment and would you consent to continue with this PR? |
I am satisfied. |
miri64
added
the
CI: ready for build
miri64
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Until now,
skaldwas implemented in a way that all active advertisings were using the same, compile-time-configured, advertising interval. But making the interval configurable per context makeskaldmuch more flexible, trading 4 byte in RAM overhead and a single pointer deref - quite OK I'd say :-) The actual change consists of two lines, adding theadv_itvl_msfield to the context struct and substitutingCONFIG_SKALD_INTERVAL_MSforctx->adv_itvl_msin the implementation. All the rest is just the adaption of the two ibeaon and eddystone wrappers...Testing procedure
Run the two provided
skaldexamples (examples/skald_ibeacon) and (examples/skald_eddystone) and verify they still advertise as expected.Issues/PRs references
none