Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/net/link_layer/csma_sender: use public xtimer_now() #17731

Merged
merged 1 commit into from
Mar 3, 2022
Merged

sys/net/link_layer/csma_sender: use public xtimer_now() #17731

merged 1 commit into from
Mar 3, 2022

Conversation

fjmolinas
Copy link
Contributor

Contribution description

The private API should not be used.

Testing procedure

  • green murdock

Issues/PRs references

Found in #17365

@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 2, 2022
@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels Mar 2, 2022
kaspar030
kaspar030 approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030 kaspar030 enabled auto-merge March 2, 2022 10:00
@fjmolinas fjmolinas removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 2, 2022
@fjmolinas fjmolinas force-pushed the pr_csma_sender_use_public_api branch from b9d2143 to 8378b40 Compare March 2, 2022 11:06
@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 3, 2022
kaspar030
kaspar030 approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 3, 2022
@kaspar030 kaspar030 merged commit c7c5279 into RIOT-OS:master Mar 3, 2022
@fjmolinas fjmolinas deleted the pr_csma_sender_use_public_api branch March 24, 2022 08:31
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@kfessel kfessel Awaiting requested review from kfessel

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

Assignees
No one assigned
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.04
Development

Successfully merging this pull request may close these issues.
4 participants
@fjmolinas @kaspar030 @benpicco @OlegHahm