gnrc_lorawan: fix gnrc_pktbuf_release_error (introduced by #16080) #16617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes an issue introduced by #16080, in which the wrong pktsnip is released on TX errors.
I removed the
head
variable and asserted "payload" just to avoid this kind of mistakes in the future.Testing procedure
It's quite hard to test LoRAWAN right now if we don't have working setups with TTN, but I have a running instance of Chirpstack. I will post results ASAP.
If the transmissions fails (e.g the node didn't join), there's an assertion on master:
With this PR:
Issues/PRs references
#16080