-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/wakaama: add Light Control object implementation #16204
pkg/wakaama: add Light Control object implementation #16204
Conversation
99e31d6
to
544daf4
Compare
@cgundogan @leandrolanzieri is this of interest for the next release? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
Is there a way to have a unit or integration test for this? |
544daf4
to
414226c
Compare
For this I think it would make sense to think about a generic LwM2M object tester application that can be extended as we add our object implementations. Probably out of the scope of this one. I rebased and updated some things now:
|
414226c
to
00a752a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found very little to complain - you are either a genius or I am sloppy at reviewing.
Still have to test it.
LGTM! There are some static test issues you might want to fix? I tested it on native and it works fine! |
c201cda
to
644bae5
Compare
Squashed! |
644bae5
to
02e254a
Compare
02e254a
to
ea2440f
Compare
Thanks for the review! |
Contribution description
This PR adds the implementation of the Light Control LwM2M object. The object takes care of the resources, the actual interaction to the light is done via a callback registered during instance creation. The wakaama example has been adapted to instantiate this object once
if the.LED0
is presentTesting procedure
Issues/PRs references
None