Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/wakaama: add patch to cast macro to time_t #15934

Merged
merged 1 commit into from
Feb 6, 2021
Merged

pkg/wakaama: add patch to cast macro to time_t #15934

merged 1 commit into from
Feb 6, 2021

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

There seems to be some issue on native (which may involve certain versions of toolchains, see #15870 and #15878), that leads to floating point exceptions when using some packages. This adds a patch to the wakaama package to cast a float macro to time_t, which seems to fix the issue.

Testing procedure

  • Follow the instructions in examples/wakaama. Check that with current master the node raises an exception when the registration is triggered. With this PR it should work normally.

Issues/PRs references

Maybe related to #15870 and #15878

@leandrolanzieri
pkg/wakaama: cast macro to time_t
0492cc5 
Currently on some toolchains the wakaama package is raising a floating
point exception on native. This seems to be fixing the issue.
@leandrolanzieri leandrolanzieri added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: pkg Area: External package ports labels Feb 5, 2021
maribu
maribu approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 5, 2021
@maribu maribu merged commit 83fbde1 into RIOT-OS:master Feb 6, 2021
@leandrolanzieri leandrolanzieri deleted the pr/pkg/wakaama_patch_native_exception branch February 6, 2021 13:33
@leandrolanzieri leandrolanzieri added this to the Release 2021.04 milestone Feb 6, 2021
@leandrolanzieri leandrolanzieri added the Release notes: added Set on PRs that have been processed into the release notes for the current release. label Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Release notes: added Set on PRs that have been processed into the release notes for the current release. Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2021.04
Development

Successfully merging this pull request may close these issues.
3 participants
@leandrolanzieri @maribu @benpicco