Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add const to ciphers #15156

Merged
merged 5 commits into from
Oct 5, 2020
Merged

Add const to ciphers #15156

merged 5 commits into from
Oct 5, 2020

Conversation

fabian18
Copy link
Contributor

@fabian18 fabian18 commented Oct 5, 2020 •
edited
Loading

Contribution description

I just added a const to the cipher functions because the pointer to the cipher can be const.

Testing procedure

cd tests/sys_crypto
make BOARD=nucleo-f767zi flash term


2020-10-05 11:04:15,374 # Connect to serial port /dev/ttyACM0
Welcome to pyterm!
Type '/exit' to exit.
s
2020-10-05 11:04:18,882 # START
2020-10-05 11:04:18,889 # main(): This is RIOT! (Version: 2020.10-devel-1802-g75101-add_const_to_ciphers)
2020-10-05 11:04:18,918 # ..................................
2020-10-05 11:04:18,919 # OK (34 tests)

Issues/PRs references

#15150

benpicco
benpicco reviewed Oct 5, 2020
View reviewed changes
sys/crypto/modes/ecb.c Outdated Show resolved Hide resolved
benpicco
benpicco reviewed Oct 5, 2020
View reviewed changes
sys/crypto/modes/ecb.c Outdated Show resolved Hide resolved
benpicco
benpicco reviewed Oct 5, 2020
View reviewed changes
sys/crypto/modes/ccm.c Outdated Show resolved Hide resolved
@benpicco benpicco added Area: crypto Area: Cryptographic libraries Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Oct 5, 2020
@fabian18
Copy link
Contributor Author

fabian18 commented Oct 5, 2020

Oh there were even a bit more places to add a const.

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 5, 2020
@benpicco
Copy link
Contributor

benpicco commented Oct 5, 2020

Please squash.

benpicco
benpicco approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thank you!

@benpicco benpicco added Area: crypto Area: Cryptographic libraries Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation and removed Area: crypto Area: Cryptographic libraries Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Oct 5, 2020
@fabian18
Copy link
Contributor Author

fabian18 commented Oct 5, 2020

Thank you too

@bergzand bergzand merged commit 31ce4ca into RIOT-OS:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: crypto Area: Cryptographic libraries CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabian18 @benpicco @bergzand