transport_layer: Splitting UDP and TCP #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgundogan
force-pushed
the
transport_layer_refactoring
branch
from
c057150
to
dde327a
Compare
| USEMODULE_INCLUDES += $(RIOTBASE)/sys/net/include | ||
| endif | ||
| ifneq (,$(filter tcp,$(USEMODULE))) | ||
| USEMODULE_INCLUDES += $(RIOTBASE)/sys/net/transport_layer/socket_base |
There was a problem hiding this comment.
Dislike. Why not put these into sys/net/include, too?
cgundogan
force-pushed
the
transport_layer_refactoring
branch
2 times, most recently
from
16bde98
to
0a6e72c
Compare
cgundogan
force-pushed
the
transport_layer_refactoring
branch
2 times, most recently
from
0916d6f
to
5d302df
Compare
|
Does someone understand why Travis fails for qemu on arbitrary applications? |
|
Yes, download.riot-os.org is down. |
|
Ah, thanks. For some reason someone shut down the Jenkins server which hosts also |
|
Maybe we can host that on ftp.fu-berlin.de instead? |
|
Broken licenses should be fixed by merging cgundogan#1. |
|
ACK. Rebase (to remove the merge commit) and go! |
Currently, the tcp and udp implementations are bound to each other in a module called *destiny*. Thus, when using only one of them then the other one gets also compiled into the binary and initialized, which results in unnecessary RAM usage and workload for the CPU. The approach in this PR defines a common module named *socket_base*, which contains functions used by the posix layer. Compiled by it's own, those functions return negative error codes, to symbolize upper layers that they are not supported. When also including the modules *udp* or *tcp* respectively, functions from *socket_base* get overwritten with the correct functionality. Defining *udp* or *tcp* in a Makefile also includes *socket_base*. Defining *pnet* in a Makefile also includes *socket_base*.
cgundogan
force-pushed
the
transport_layer_refactoring
branch
from
f51f9d9
to
710c7e6
Compare
|
I did a rebase/squash. waiting for travis to finish now |
|
Yay! \o/ |
OlegHahm
added a commit
that referenced
this pull request
Sep 11, 2014
transport_layer: Splitting UDP and TCP
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the tcp and udp implementations are bound to each other in a
module called destiny. Thus, when using only one of them then the
other one gets also compiled into the binary and initialized,
which results in unnecessary RAM usage and workload for the CPU.
The approach in this PR defines a common module named socket_base,
which contains functions used by the posix layer. Compiled by it's own,
those functions return negative error codes, to symbolize upper layers
that they are not supported. When also including the modules udp or
tcp respectively, functions from socket_base get overwritten with the
correct functionality.
Defining udp or tcp in a Makefile also includes socket_base.
Defining pnet in a Makefile also includes socket_base.
Defining transport_layer in a Makefile includes udp and tcp.