drivers/periph: Remove UART from device_enums.h #14916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrKevinWeiss
added
Type: cleanup
|
...this has been an effective form of procrastination. |
MrKevinWeiss
force-pushed
the
pr/slwstk6220a
branch
from
3cd1248
to
62d1ebb
Compare
|
sorry for not running static checks... Should be better now, but we will see. |
MrKevinWeiss
force-pushed
the
pr/slwstk6220a
branch
from
62d1ebb
to
76a90f7
Compare
|
I can wait until this doc_check issue is solved as it seems to be more a CI problem. |
MrKevinWeiss
force-pushed
the
pr/slwstk6220a
branch
from
ded9a06
to
e7878ec
Compare
|
Looks like CI is happy, just waiting for a review. |
aabadie
reviewed
Sep 8, 2020
cpu/lm4f120/periph/uart.c
Outdated
| /* Check to make sure the UART peripheral is present */ | ||
| if(!ROM_SysCtlPeripheralPresent(SYSCTL_PERIPH_UART0)){ | ||
| if (!ROM_SysCtlPeripheralPresent(SYSCTL_PERIPH_UART0)){ |
There was a problem hiding this comment.
Suggested change
| if (!ROM_SysCtlPeripheralPresent(SYSCTL_PERIPH_UART0)){ | |
| if (!ROM_SysCtlPeripheralPresent(SYSCTL_PERIPH_UART0)) { |
cpu/lm4f120/periph/uart.c
Outdated
| return UART_NODEV; | ||
| } | ||
|
|
||
| int res = init_base(uart, baudrate); | ||
| if(res != UART_OK){ | ||
| if (res != UART_OK){ |
There was a problem hiding this comment.
Suggested change
| if (res != UART_OK){ | |
| if (res != UART_OK) { |
cpu/lm4f120/periph/uart.c
Outdated
Comment on lines
132
to
135
| if (ulStatus & (UART_INT_RX | UART_INT_RT)) | ||
| { | ||
| while(ROM_UARTCharsAvail(UART0_BASE)) | ||
| while (ROM_UARTCharsAvail(UART0_BASE)) | ||
| { |
There was a problem hiding this comment.
Suggested change
| if (ulStatus & (UART_INT_RX | UART_INT_RT)) | |
| { | |
| while(ROM_UARTCharsAvail(UART0_BASE)) | |
| while (ROM_UARTCharsAvail(UART0_BASE)) | |
| { | |
| if (ulStatus & (UART_INT_RX | UART_INT_RT)) { | |
| while (ROM_UARTCharsAvail(UART0_BASE)) { |
(doesn't render well sorry)
|
Thanks, will get to it tomorrow morning! |
Change uart dev 1 to use UART2 on p9 and p10 since p0 and p1 are not accessable
MrKevinWeiss
force-pushed
the
pr/slwstk6220a
branch
from
e7878ec
to
bdeb395
Compare
|
rebased and squash with the fixes (hope that is OK). |
aabadie
approved these changes
Sep 9, 2020
|
Thanks for the review @aabadie ! |
|
hmmm something happened with the |
|
That was annoying, OK should be fix -> #14990 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
In order to remove the need for the legacy device_enums and clean things up all boards using UART definitions from device_enums have been updated.
This includes:
ek-lm4f120xl- Since only UART0 was implemented, asserts ensure only that uart is implemented.mbed_lpc1768- Implementation for all uarts are added assuming pins are together, periph conf was updated for uart 1 to be on p9 and p10 since they were previously inaccessablemsb-430- Implementation does not require device_enums.hmsb-430h- Implementation does not require device_enums.hnrf6310- Implementation does not require device_enums.hseeeduino_arch-pro- Implementation for all uarts are added assuming pins are togethertelosb- Implementation does not require device_enums.hz1- Implementation does not require device_enums.hSome generic cleanup also applied to files as new static checks have shown warnings.
Testing procedure
Use
tests/periph_uartto ensure communication (stdio uart) and any additional uarts.The
lpc1768cpu change was verified with thembed_lpc1768by enabling uart 1 and reading loopback messages.Issues/PRs references
Step forward with #7941